Staging: rtl8723bs: os_dep
PATCH 1/5 Staging: rtl8723bs: os_dep
ERROR: do not initialise statics to NULL
Signed-off-by Paul McQuade <[email protected]>
--- drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/os_dep/rtw_proc.c +1 -1
@@ -19,7 +19,7 @@#ifdef PROC_DEBUG -static struct proc_dir_entry *rtw_proc =NULL ; +static struct proc_dir_entry *rtw_proc;#define RTW_PROC_NAME "rtl8723bs"
Signature · 6 lines
2.16.2 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
PATCH 2/5 Staging: rtl8723bs: os_dep Spacing issue
ERROR: spaces required around that '<' (ctx:VxV)
Signed-off-by Paul McQuade <[email protected]>
--- drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/staging/rtl8723bs/os_dep/rtw_proc.c +8 -8
@@ -142,7 +142,7 @@ int rtw_drv_proc_init(void) goto exit; } -for (i =0 ;i<drv_proc_hdls_num;i++) { +for (i =0 ; i < drv_proc_hdls_num; i++) { entry =rtw_proc_create_entry (drv_proc_hdls[i].name, rtw_proc, &rtw_drv_proc_fops, (void *)i);if (!entry) {rtw_warn_on (1 );
@@ -163,7 +163,7 @@ void rtw_drv_proc_deinit(void)if (rtw_proc ==NULL )return ; -for (i =0 ;i<drv_proc_hdls_num;i++) +for (i =0 ; i < drv_proc_hdls_num; i++)remove_proc_entry (drv_proc_hdls[i].name, rtw_proc);remove_proc_entry (RTW_PROC_NAME , get_proc_net);
@@ -341,7 +341,7 @@ static int proc_get_cam_cache(struct seq_file *m, void *v)/* "MK", "GK", "MFB", "valid" */ ); -for (i =0 ;i<32 ;i++) { +for (i =0 ; i <32 ; i++) {if (dvobj->cam_cache[i].ctrl !=0 )DBG_871X_SEL_NL (m,"%2u 0x%04x " MAC_FMT " " KEY_FMT " %3u %-7s" /* %2u %2u 0x%02x %5u" */
@@ -663,7 +663,7 @@ static struct proc_dir_entry *rtw_odm_proc_init(struct net_device *dev) adapter->dir_odm = dir_odm; -for (i =0 ;i<odm_proc_hdls_num;i++) { +for (i =0 ; i < odm_proc_hdls_num; i++) { entry =rtw_proc_create_entry (odm_proc_hdls[i].name, dir_odm, &rtw_odm_proc_fops, (void *)i);if (!entry) {rtw_warn_on (1 );
@@ -687,7 +687,7 @@ static void rtw_odm_proc_deinit(struct adapter *adapter)return ; } -for (i =0 ;i<odm_proc_hdls_num;i++) +for (i =0 ; i < odm_proc_hdls_num; i++)remove_proc_entry (odm_proc_hdls[i].name, dir_odm);remove_proc_entry ("odm" , adapter->dir_dev);
@@ -721,7 +721,7 @@ struct proc_dir_entry *rtw_adapter_proc_init(struct net_device *dev) adapter->dir_dev = dir_dev; -for (i =0 ;i<adapter_proc_hdls_num;i++) { +for (i =0 ; i < adapter_proc_hdls_num; i++) { entry =rtw_proc_create_entry (adapter_proc_hdls[i].name, dir_dev, &rtw_adapter_proc_fops, (void *)i);if (!entry) {rtw_warn_on (1 );
@@ -749,7 +749,7 @@ void rtw_adapter_proc_deinit(struct net_device *dev)return ; } -for (i =0 ;i<adapter_proc_hdls_num;i++) +for (i =0 ; i < adapter_proc_hdls_num; i++)remove_proc_entry (adapter_proc_hdls[i].name, dir_dev);rtw_odm_proc_deinit (adapter);
@@ -773,7 +773,7 @@ void rtw_adapter_proc_replace(struct net_device *dev)return ; } -for (i =0 ;i<adapter_proc_hdls_num;i++) +for (i =0 ; i < adapter_proc_hdls_num; i++)remove_proc_entry (adapter_proc_hdls[i].name, dir_dev);rtw_odm_proc_deinit (adapter);
Signature · 6 lines
2.16.2 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
PATCH 3/5 Staging:rtl8723bs:os_dep braces not necessary
In reply to Paul McQuadeWARNING: braces {} are not necessary for any arm of this statement
Signed-off-by Paul McQuade <[email protected]>
--- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/os_dep/recv_linux.c +3 -3
@@ -181,11 +181,11 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, _pkt *pkt, struct rx_pkt pkt->dev = padapter->pnetdev;#ifdef CONFIG_TCP_CSUM_OFFLOAD_RX -if ((pattrib->tcpchk_valid ==1 ) && (pattrib->tcp_chkrpt ==1 )) { +if ((pattrib->tcpchk_valid ==1 ) && (pattrib->tcp_chkrpt ==1 )) pkt->ip_summed =CHECKSUM_UNNECESSARY ; - }else { +else pkt->ip_summed =CHECKSUM_NONE ; - } +#else /* !CONFIG_TCP_CSUM_OFFLOAD_RX */ pkt->ip_summed =CHECKSUM_NONE ;#endif /* CONFIG_TCP_CSUM_OFFLOAD_RX */
Signature · 6 lines
2.16.2 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
PATCH 4/5 Staging:rtl8723bs:os_dep blank line needed
In reply to Paul McQuadeWARNING: Missing a blank line after declarations
Signed-off-by Paul McQuade <[email protected]>
--- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/rtl8723bs/os_dep/recv_linux.c +1 -0
@@ -43,6 +43,7 @@ void rtw_os_recv_resource_free(struct recv_priv *precvpriv) {sint i;union recv_frame *precvframe; + precvframe = (union recv_frame *) precvpriv->precv_frame_buf;for (i =0 ; i <NR_RECVFRAME ; i++)
Signature · 6 lines
2.16.2 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
PATCH 5/5 Staging:rtl8723bs:os_dep Fixed braces
In reply to Paul McQuadeERROR: that open brace { should be on the previous line
Signed-off-by Paul McQuade <[email protected]>
--- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/staging/rtl8723bs/os_dep/recv_linux.c +3 -6
@@ -20,8 +20,7 @@void rtw_os_free_recvframe (union recv_frame *precvframe) { -if (precvframe->u.hdr.pkt) - { +if (precvframe->u.hdr.pkt) {dev_kfree_skb_any (precvframe->u.hdr.pkt);/* free skb by driver */ precvframe->u.hdr.pkt =NULL ;
@@ -46,10 +45,8 @@ void rtw_os_recv_resource_free(struct recv_priv *precvpriv) precvframe = (union recv_frame *) precvpriv->precv_frame_buf; -for (i =0 ; i <NR_RECVFRAME ; i++) - { -if (precvframe->u.hdr.pkt) - { +for (i =0 ; i <NR_RECVFRAME ; i++) { +if (precvframe->u.hdr.pkt) {dev_kfree_skb_any (precvframe->u.hdr.pkt);/* free skb by driver */ precvframe->u.hdr.pkt =NULL ; }
Signature · 6 lines
2.16.2 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Greg KH
maintainerQuoted 1 line · Paul McQuade
ERROR: do not initialise statics to NULL
You are going to have to do a bit more writing in the changelog than just dumping in random output from checkpatch.pl. I know that's where that line came from, but no one else will.
And your subject lines also need a lot of work.
Please fix up for all of these patches and resend the whole series.
thanks,
greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel