drm/msm/dsi: use correct enum in dsi_get_cmd_fmt
PATCH 1/1 drm/msm/dsi: use correct enum in dsi_get_cmd_fmt
The function dsi_get_cmd_fmt returns enum dsi_cmd_dst_format, use the correct enum value also for MIPI_DSI_FMT_RGB666/_PACKED.
This has been discovered using clang:
drivers/gpu/drm/msm/dsi/dsi_host.c:743:35: warning: implicit conversion
from enumeration type 'enum dsi_vid_dst_format' to different enumeration type 'enum dsi_cmd_dst_format' [-Wenum-conversion]
case MIPI_DSI_FMT_RGB666: return VID_DST_FORMAT_RGB666;
~~~~~~ ^~~~~~~~~~~~~~~~~~~~~
--- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/dsi/dsi_host.c +1 -1
@@ -740,7 +740,7 @@ static inline enum dsi_cmd_dst_format dsi_get_cmd_fmt(switch (mipi_fmt) {case MIPI_DSI_FMT_RGB888 :return CMD_DST_FORMAT_RGB888 ;case MIPI_DSI_FMT_RGB666_PACKED : -case MIPI_DSI_FMT_RGB666 :return VID_DST_FORMAT_RGB666 ; +case MIPI_DSI_FMT_RGB666 :return CMD_DST_FORMAT_RGB666 ;case MIPI_DSI_FMT_RGB565 :return CMD_DST_FORMAT_RGB565 ;default :return CMD_DST_FORMAT_RGB888 ; }
Signature · 6 lines
2.16.2 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 11 lines · Stefan Agner
The function
dsi_get_cmd_fmtreturns enumdsi_cmd_dst_format, use the correct enum value also for MIPI_DSI_FMT_RGB666/_PACKED.This has been discovered using clang:
drivers/gpu/drm/msm/dsi/dsi_host.c:743:35: warning: implicit conversion
from enumeration type 'enumdsi_vid_dst_format' to different enumeration type 'enumdsi_cmd_dst_format' [-Wenum-conversion]
caseMIPI_DSI_FMT_RGB666: returnVID_DST_FORMAT_RGB666;
~~~~~~ ^~~~~~~~~~~~~~~~~~~~~Signed-off-by Stefan Agner <[email protected]>
Archit
Quoted 10 lines
--- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/msm/dsi/dsi_host.c +0
-0
drivers/gpu/drm/msm/dsi/dsi_host.c static inline enum dsi_cmd_dst_format dsi_get_cmd_fmt( · line 746
Quoted 8 lines
drivers/gpu/drm/msm/dsi/dsi_host.c +1
-1@@ -740,7 +740,7 @@ static inline enum dsi_cmd_dst_format dsi_get_cmd_fmt(switch (mipi_fmt) {case MIPI_DSI_FMT_RGB888 :return CMD_DST_FORMAT_RGB888 ;case MIPI_DSI_FMT_RGB666_PACKED : -case MIPI_DSI_FMT_RGB666 :return VID_DST_FORMAT_RGB666 ; +case MIPI_DSI_FMT_RGB666 :return CMD_DST_FORMAT_RGB666 ;case MIPI_DSI_FMT_RGB565 :return CMD_DST_FORMAT_RGB565 ;default :return CMD_DST_FORMAT_RGB888 ; }
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno