Skip to contentSkip to conversation

USB: misc: uss720: more vendor/product ID's

DISCUSSION Greg KH 1 participant 1 message Mar 20, 2018 USB

lore
Share & tools
lore

Greg KH

author
#0 lore raw
Quoted 13 lines · Daniel Gimpelevich
Quoted 3 lines · Greg KH

Who is "Rab" and why do you need to name who added what id to the patch?

I copied that part from the web page I referenced in the commit message. It's evidently a reference to the page's author. I tried to send an e-mail to the address at the bottom of the page, with no response. I also CC'ed from git send-email.

Quoted 4 lines

What is more useful is a description of the device types, not who added
the new id, can you do that instead?

Quoted 8 lines

For the "Rab" devices, there is a wealth of such information on the aforementioned web page. I added the info for the ones I have into the commit message.

Quoted 1 line

It doesn't say that Fabio added this one below, are you sure?

It says that in the commit that added it:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/misc/uss720.c?id=ecc1624a2fff45780959efbcb73ace18fdb3c58d

Ok, but that isn't needed in the comments of the code.

Put the device "type" or "name" as a comment, that makes more sense and follows what almost all other drivers do.

Quoted 5 lines
Quoted 2 lines

Always use scripts/get_maintainer.pl to figure out who to cc: on the patches, otherwise the maintainer might miss it :(

Hmm, I simply looked in the MAINTAINERS file instead, which has no entry for this driver.

If there is no default, it falls back to the maintainer(s) of the subsystem, which get_maintainer.pl knows how to handle.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html