scsi: dpt_i2o: Use after free in I2ORESETCMD ioctl

PATCH New Dan Carpenter 1 participant 1 message Mar 21, 2018

Subsystems (2)

SCSI Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2018-03-21 08:09 UTC #0 lore raw

PATCH 1/1 scsi: dpt_i2o: Use after free in I2ORESETCMD ioctl

Here is another use after free if we reset the card. The adpt_hba_reset() function frees "pHba" on error.

Signed-off-by Dan Carpenter <[email protected]>

drivers/scsi/dpt_i2o.c +8 -5

index 3c667b23a801..359e0acfbc7c 100644
@@ -2046,13 +2046,16 @@ static int adpt_ioctl(struct inode *inode, struct file *file, uint cmd, ulong ar
 		}
 		break;
 		}
-	case I2ORESETCMD:
-		if(pHba->host)
-			spin_lock_irqsave(pHba->host->host_lock, flags);
+	case I2ORESETCMD: {
+		struct Scsi_Host *shost = pHba->host;
+
+		if (shost)
+			spin_lock_irqsave(shost->host_lock, flags);
 		adpt_hba_reset(pHba);
-		if(pHba->host)
-			spin_unlock_irqrestore(pHba->host->host_lock, flags);
+		if (shost)
+			spin_unlock_irqrestore(shost->host_lock, flags);
 		break;
+	}
 	case I2ORESCANCMD:
 		adpt_rescan(pHba);
 		break;