drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs
PATCH 1/1 drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs
The checks are misleading and not required [1].
[1] https://lkml.org/lkml/2018/3/19/1792
Addresses-Coverity-ID: 1466017
Cc Chris Wilson <[email protected]>
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/gpu/drm/i915/gvt/scheduler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gvt/scheduler.c +1 -1
@@ -74,7 +74,7 @@ static void sr_oa_regs(struct intel_vgpu_workload *workload, i915_mmio_reg_offset(EU_PERF_CNTL6), }; -if (!workload || !reg_state || workload->ring_id !=RCS ) +if (workload->ring_id !=RCS )return ;if (save) {
Signature · 1 line
2.7.4
Quoting Gustavo A. R. Silva (2018-03-22 18:21:54)
Quoted 7 lines
The checks are misleading and not required [1].
[1] https://lkml.org/lkml/2018/3/19/1792
Addresses-Coverity-ID: 1466017
Cc Chris Wilson <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Chris Wilson <[email protected]>
Zhenyu?
-Chris
Quoted 10 lines · Chris Wilson
Quoting Gustavo A. R. Silva (2018-03-22 18:21:54)
Quoted 7 lines
The checks are misleading and not required [1].
[1] https://lkml.org/lkml/2018/3/19/1792
Addresses-Coverity-ID: 1466017
Cc Chris Wilson <[email protected]>Signed-off-by Gustavo A. R. Silva <[email protected]>Reviewed-by Chris Wilson <[email protected]>
Looks good to me, I will pick this up, thanks!
Signature · 3 lines
Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel