Skip to contentSkip to conversation

drm/gma500: simplify a condition in psbfb_mmap()

PATCH New Dan Carpenter 1 participant 1 message Mar 23, 2018

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/gma500: simplify a condition in psbfb_mmap()

Since we enforce that "vma->vm_pgoff" has to be zero it means we don't need an additional cap on the upper bound.

drivers/gpu/drm/gma500/framebuffer.c +1 -3
index cb0a2ae916e0..a6732bffb2e2 100644
@@ -166,9 +166,7 @@ static int psbfb_mmap(struct fb_info *info, struct vm_area_struct *vma)
 	struct psb_fbdev *fbdev = info->par;
 	struct psb_framebuffer *psbfb = &fbdev->pfb;
 
-	if (vma->vm_pgoff != 0)
-		return -EINVAL;
-	if (vma->vm_pgoff > (~0UL >> PAGE_SHIFT))
+	if (vma->vm_pgoff)
 		return -EINVAL;
 
 	if (!psbfb->addr_space)