nfsd: Do not refuse to serve out of cache
Subsystems (2)
PATCH 1/1 nfsd: Do not refuse to serve out of cache
Currently the knfsd replay cache appears to try to refuse replying to retries that come within 200ms of the cache entry being created. That makes limited sense in today's world of high speed TCP.
--- fs/nfsd/cache.h | 5 ----- fs/nfsd/nfscache.c | 6 ++---- 2 files changed, 2 insertions(+), 9 deletions(-)
fs/nfsd/cache.h +0 -5
@@ -67,11 +67,6 @@ enum { RC_REPLBUFF, }; -/* -* If requests are retransmitted within this interval, they're dropped. -*/ -#define RC_DELAY (HZ/5) -/* Cache entries expire after this time period */ #define RC_EXPIRE (120 * HZ)
fs/nfsd/nfscache.c +2 -4
@@ -394,7 +394,6 @@ nfsd_cache_lookup(struct svc_rqst *rqstp)__wsum csum;u32 hash =nfsd_cache_hash (xid);struct nfsd_drc_bucket *b = &drc_hashtbl[hash]; -unsigned long age;int type = rqstp->rq_cachetype;int rtn =RC_DOIT ;
@@ -461,12 +460,11 @@ nfsd_cache_lookup(struct svc_rqst *rqstp) found_entry: nfsdstats.rchits++;/* We found a matching entry which is either in progress or done. */ - age = jiffies - rp->c_timestamp;lru_put_end (b, rp); rtn =RC_DROPIT ; -/* Request being processed or excessive rexmits */ -if (rp->c_state ==RC_INPROG || age <RC_DELAY ) +/* Request being processed */ +if (rp->c_state ==RC_INPROG ) goto out;/* From the hall of fame of impractical attacks:
Signature · 1 line
2.14.3
Quoted 45 lines · Trond Myklebust
Currently the knfsd replay cache appears to try to refuse replying to retries that come within 200ms of the cache entry being created. That makes limited sense in today's world of high speed TCP.
Signed-off-by Trond Myklebust <[email protected]>--- fs/nfsd/cache.h | 5 ----- fs/nfsd/nfscache.c | 6 ++---- 2 files changed, 2 insertions(+), 9 deletions(-)fs/nfsd/cache.h +0
-2@@ -67,11 +67,6 @@ enum { RC_REPLBUFF, }; -/* -* If requests are retransmitted within this interval, they're dropped.
- */fs/nfsd/cache.h +0
-2-#define RC_DELAY (HZ/5) -/* Cache entries expire after this time period */ #define RC_EXPIRE (120 * HZ)fs/nfsd/nfscache.c +0
-1@@ -394,7 +394,6 @@ nfsd_cache_lookup(struct svc_rqst *rqstp)__wsum csum;u32 hash =nfsd_cache_hash (xid);struct nfsd_drc_bucket *b = &drc_hashtbl[hash]; -unsigned long age;int type = rqstp->rq_cachetype;int rtn =RC_DOIT ;@@ -461,12 +460,11 @@ nfsd_cache_lookup(struct svc_rqst *rqstp) found_entry: nfsdstats.rchits++;/* We found a matching entry which is either in progress or done. */
fs/nfsd/nfscache.c +0
-1- age = jiffies - rp->c_timestamp;
fs/nfsd/nfscache.c nfsd_cache_lookup(struct svc_rqst *rqstp) · line 470
Quoted 10 lines
fs/nfsd/nfscache.c +2
-2lru_put_end (b, rp); rtn =RC_DROPIT ; -/* Request being processed or excessive rexmits */ -if (rp->c_state ==RC_INPROG || age <RC_DELAY ) +/* Request being processed */ +if (rp->c_state ==RC_INPROG ) goto out;/* From the hall of fame of impractical attacks:
That condition always looked a bit suspicious to me.
Applying, thanks.
Quoted 4 lines · Jeff Layton
Quoted 3 lines · Trond Myklebust
Currently the knfsd replay cache appears to try to refuse replying to retries that come within 200ms of the cache entry being created. That makes limited sense in today's world of high speed TCP.
Trond gave me some helpful context in person, I may tag that onto the changelog:
After a TCP disconnection, a client can very easily reconnect and retry an rpc in less than 200ms. If this logic drops that retry, however, the client may be quite slow to retry again. This logic is original to the first reply cache implementation in 2.1, and may have made more sense for UDP clients that retried much more frequently.
We're still dropping on finding the original request still in progress, which can cause the same problem, though it's less likely.
Note svc_check_conn_limits is often the cause of those disconnections. We may want to fix that some day.
--b.
Quoted 56 lines
Quoted 42 lines
Signed-off-by Trond Myklebust <[email protected]>--- fs/nfsd/cache.h | 5 ----- fs/nfsd/nfscache.c | 6 ++---- 2 files changed, 2 insertions(+), 9 deletions(-)fs/nfsd/cache.h +0
-2@@ -67,11 +67,6 @@ enum { RC_REPLBUFF, }; -/* -* If requests are retransmitted within this interval, they're dropped.
- */fs/nfsd/cache.h +0
-2-#define RC_DELAY (HZ/5) -/* Cache entries expire after this time period */ #define RC_EXPIRE (120 * HZ)fs/nfsd/nfscache.c +0
-1@@ -394,7 +394,6 @@ nfsd_cache_lookup(struct svc_rqst *rqstp)__wsum csum;u32 hash =nfsd_cache_hash (xid);struct nfsd_drc_bucket *b = &drc_hashtbl[hash]; -unsigned long age;int type = rqstp->rq_cachetype;int rtn =RC_DOIT ;@@ -461,12 +460,11 @@ nfsd_cache_lookup(struct svc_rqst *rqstp) found_entry: nfsdstats.rchits++;/* We found a matching entry which is either in progress or done. */
fs/nfsd/nfscache.c +0
-1- age = jiffies - rp->c_timestamp;fs/nfsd/nfscache.c nfsd_cache_lookup(struct svc_rqst *rqstp) · line 470
Quoted 10 lines
fs/nfsd/nfscache.c +2
-2lru_put_end (b, rp); rtn =RC_DROPIT ; -/* Request being processed or excessive rexmits */ -if (rp->c_state ==RC_INPROG || age <RC_DELAY ) +/* Request being processed */ +if (rp->c_state ==RC_INPROG ) goto out;/* From the hall of fame of impractical attacks: That condition always looked a bit suspicious to me.
Acked-by Jeff Layton <[email protected]>