Skip to contentSkip to conversation

usb: musb: gadget: misplaced out of bounds check

DISCUSSION Bin Liu 1 participant 1 message Mar 29, 2018 USB

lore
Share & tools
lore

Bin Liu

author
#0 lore raw
Quoted 6 lines · Greg Kroah-Hartman
Quoted 5 lines · Bin Liu

From: Heinrich Schuchardt <[email protected]>

musb->endpoints[] has array size MUSB_C_NUM_EPS.
We must check array bounds before accessing the array and not afterwards.

Quoted 7 lines
Quoted 5 lines
---
 drivers/usb/musb/musb_gadget_ep0.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

Should this also go to the stable kernels?

Your call. My understanding is this is just a potential, and the code looks wrong - checking the boundary after used it, but the ep index won't be able to over the boundary anyway. Though I don't have enough security knowledge to judge if the bug has an security hole...

Regards,
-Bin.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html