Skip to contentSkip to conversation

PM / QoS: mark expected switch fall-throughs

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Mar 30, 2018 – Apr 3, 2018

Subsystems (2)
Suspend to RAM Hibernation
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 PM / QoS: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
This code was compiled with GCC 7.3.0

 kernel/power/qos.c | 2 ++
 1 file changed, 2 insertions(+)
kernel/power/qos.c +2 -0
index 9d75039..fa39092 100644
@@ -295,6 +295,7 @@ int pm_qos_update_target(struct pm_qos_constraints *c, struct plist_node *node,
 		 * changed
 		 */
 		plist_del(node, &c->list);
+		/* fall through */
 	case PM_QOS_ADD_REQ:
 		plist_node_init(node, new_value);
 		plist_add(node, &c->list);

@@ -367,6 +368,7 @@ bool pm_qos_update_flags(struct pm_qos_flags *pqf,
 		break;
 	case PM_QOS_UPDATE_REQ:
 		pm_qos_flags_remove_req(pqf, req);
+		/* fall through */
 	case PM_QOS_ADD_REQ:
 		req->flags = val;
 		INIT_LIST_HEAD(&req->node);
Signature · 1 line
2.7.4