Skip to contentSkip to conversation

lockdep: Add print_irqtrace_events() to __warn

PATCH New Steven Rostedt 1 participant 1 message Apr 3, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lockdep: Add print_irqtrace_events() to __warn

From: "Steven Rostedt (VMware)" <[email protected]>

Running a test on a x86_32 kernel I triggered a bug that an interrupt disable/enable isn't being catched by lockdep. At least knowing where the last one was found would be helpful, but the warnings that are produced do not show this information. Even without debugging lockdep, having the WARN() display the last place hard and soft irqs were enabled or disabled is valuable.

---
 kernel/panic.c | 2 ++
 1 file changed, 2 insertions(+)
kernel/panic.c +2 -0
index 2cfef408fec9..fa8d4cc4956a 100644
@@ -554,6 +554,8 @@ void __warn(const char *file, int line, void *caller, unsigned taint,
 	else
 		dump_stack();
 
+	print_irqtrace_events(current);
+
 	print_oops_end_marker();
 
 	/* Just a warning, don't kill lockdep. */
Signature · 1 line
2.13.6