tracing: Hide global trace clock from lockdep
Steven Rostedt
maintainerRFC PATCH 1/1 tracing: Hide global trace clock from lockdep
From: Steven Rostedt (VMware) <[email protected]>
Function tracing can trace in NMIs and such. If the TSC is determined to be unstable, the tracing clock will switch to the global clock on boot up, unless "trace_clock" is specified on the kernel command line.
The global clock disables interrupts to access sched_clock_cpu(), and in doing so can be done within lockdep internals (because of function tracing and NMIs). This can trigger false lockdep splats.
The trace_clock_global() is special, best not to trace the irq logic within it.
Signed-off-by Steven Rostedt (VMware) <[email protected]>
---
kernel/trace/trace_clock.c +2 -2
@@ -96,7 +96,7 @@ u64 notrace trace_clock_global(void)int this_cpu;u64 now; -local_irq_save (flags); +raw_local_irq_save (flags); this_cpu =raw_smp_processor_id (); now =sched_clock_cpu (this_cpu);
@@ -122,7 +122,7 @@ u64 notrace trace_clock_global(void)arch_spin_unlock (&trace_clock_struct.lock); out: -local_irq_restore (flags); +raw_local_irq_restore (flags);return now; }