Skip to contentSkip to conversation

uapi: fix linux/kfd_ioctl.h userspace compilation errors

PATCH In review Dmitry V. Levin 3 participants 3 messages Apr 5, 2018 – Apr 24, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uapi: fix linux/kfd_ioctl.h userspace compilation errors

Consistently use types provided by <linux/types.h> via <drm/drm.h> to fix the following linux/kfd_ioctl.h userspace compilation errors:

/usr/include/linux/kfd_ioctl.h:266:2: error: unknown type name 'uint64_t'
uint64_t tba_addr; /* to KFD */
/usr/include/linux/kfd_ioctl.h:267:2: error: unknown type name 'uint64_t'
uint64_t tma_addr; /* to KFD */
/usr/include/linux/kfd_ioctl.h:268:2: error: unknown type name 'uint32_t'
uint32_t gpu_id; /* to KFD */
/usr/include/linux/kfd_ioctl.h:269:2: error: unknown type name 'uint32_t'
uint32_t pad;

Fixes d7b9bd2248d79 ("drm/amdkfd: Add support for user-mode trap handlers")
Cc <[email protected]> # v4.16
---
 include/uapi/linux/kfd_ioctl.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
include/uapi/linux/kfd_ioctl.h +4 -4
index f4cab5b3ba9a..111d73ba2d96 100644
@@ -263,10 +263,10 @@ struct kfd_ioctl_get_tile_config_args {
 };
 
 struct kfd_ioctl_set_trap_handler_args {
-	uint64_t tba_addr;		/* to KFD */
-	uint64_t tma_addr;		/* to KFD */
-	uint32_t gpu_id;		/* to KFD */
-	uint32_t pad;
+	__u64 tba_addr;		/* to KFD */
+	__u64 tma_addr;		/* to KFD */
+	__u32 gpu_id;		/* to KFD */
+	__u32 pad;
 };
 
 #define AMDKFD_IOCTL_BASE 'K'
Signature · 1 line
ldv
#1 lore raw

Hi,

[This is an automated email]

This commit has been processed because it contains a "Fixes:" tag, fixing commit: 6a1c9510694f drm/amdkfd: Adding new IOCTL for scratch memory v2.

The bot has also determined it's probably a bug fixing patch. (score: 20.4472)

The bot has tested the following trees: v4.16, v4.15.15, v4.14.32.

#2 lore raw
In reply to Dmitry V. Levin

Thanks, but already fixed in latest upstream tree

Oded

Quoted 39 lines · Dmitry V. Levin

Consistently use types provided by <linux/types.h> via <drm/drm.h> to fix the following linux/kfd_ioctl.h userspace compilation errors:

/usr/include/linux/kfd_ioctl.h:266:2: error: unknown type name 'uint64_t'
uint64_t tba_addr; /* to KFD */
/usr/include/linux/kfd_ioctl.h:267:2: error: unknown type name 'uint64_t'
uint64_t tma_addr; /* to KFD */
/usr/include/linux/kfd_ioctl.h:268:2: error: unknown type name 'uint32_t'
uint32_t gpu_id; /* to KFD */
/usr/include/linux/kfd_ioctl.h:269:2: error: unknown type name 'uint32_t'
uint32_t pad;

Fixes d7b9bd2248d79 ("drm/amdkfd: Add support for user-mode trap handlers")
Cc <[email protected]> # v4.16
---
 include/uapi/linux/kfd_ioctl.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
include/uapi/linux/kfd_ioctl.h +4 -5
index f4cab5b3ba9a..111d73ba2d96 100644
@@ -263,10 +263,10 @@ struct kfd_ioctl_get_tile_config_args {
 };
 
 struct kfd_ioctl_set_trap_handler_args {
-       uint64_t tba_addr;              /* to KFD */
-       uint64_t tma_addr;              /* to KFD */
-       uint32_t gpu_id;                /* to KFD */
-       uint32_t pad;
+       __u64 tba_addr;         /* to KFD */
+       __u64 tma_addr;         /* to KFD */
+       __u32 gpu_id;           /* to KFD */
+       __u32 pad;
 };
 
 #define AMDKFD_IOCTL_BASE 'K'
--
Quoted 1 line

ldv

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel