swiotlb: remove an unecessary NULL check

PATCH New Dan Carpenter 1 participant 1 message Apr 5, 2018

Subsystems (2)

Kernel janitors Library code

lore

Share & tools

lore

Dan Carpenter

author

2018-04-05 11:19 UTC #0 lore raw

PATCH 1/1 swiotlb: remove an unecessary NULL check

Smatch complains here:

lib/swiotlb.c:730 swiotlb_alloc_buffer()
warn: variable dereferenced before check 'dev' (see line 716)

"dev" isn't ever NULL in this function so we can just remove the check.

Signed-off-by Dan Carpenter <[email protected]>

lib/swiotlb.c +1 -1

index 47aeb04c1997..51dde88e50a3 100644
@@ -727,7 +727,7 @@ swiotlb_alloc_buffer(struct device *dev, size_t size, dma_addr_t *dma_handle,
 
 out_unmap:
 	dev_warn(dev, "hwdev DMA mask = 0x%016Lx, dev_addr = 0x%016Lx\n",
-		(unsigned long long)(dev ? dev->coherent_dma_mask : 0),
+		(unsigned long long)dev->coherent_dma_mask,
 		(unsigned long long)*dma_handle);
 
 	/*