drm/i915: Enclose for_each_engine_masked macro arguments in parentheses
Subsystems (2)
Tvrtko Ursulin
maintainerPATCH 1/1 drm/i915: Enclose for_each_engine_masked macro arguments in parentheses
From: Tvrtko Ursulin <[email protected]>
Enclose for_each_engine_masked macro arguments in parentheses.
--- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +2 -2
@@ -2149,8 +2149,8 @@ static inline struct drm_i915_private *huc_to_i915(struct intel_huc *huc)/* Iterator over subset of engines selected by mask */ #define for_each_engine_masked (engine__, dev_priv__, mask__, tmp__) \ - for (tmp__ = mask__ & INTEL_INFO(dev_priv__)->ring_mask; \ - tmp__ ? (engine__ = (dev_priv__)->engine[__mask_next_bit(tmp__)]), 1 : 0; ) + for ((tmp__) = (mask__) & INTEL_INFO(dev_priv__)->ring_mask; \ + (tmp__) ? ((engine__) = (dev_priv__)->engine[__mask_next_bit(tmp__)]), 1 : 0; )enum hdmi_force_audio {HDMI_AUDIO_OFF_DVI =-2 ,/* no aux data for HDMI-DVI converter */
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Tvrtko Ursulin (2018-04-06 10:24:17)
Quoted 14 lines
From: Tvrtko Ursulin <[email protected]>
Enclose
for_each_engine_maskedmacro arguments in parentheses.Signed-off-by Tvrtko Ursulin <[email protected]>--- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_drv.h +0
-0
drivers/gpu/drm/i915/i915_drv.h static inline struct drm_i915_private *huc_to_i915(struct intel_huc *huc) · line 2153
Quoted 7 lines
drivers/gpu/drm/i915/i915_drv.h +2
-2@@ -2149,8 +2149,8 @@ static inline struct drm_i915_private *huc_to_i915(struct intel_huc *huc)/* Iterator over subset of engines selected by mask */ #define for_each_engine_masked (engine__, dev_priv__, mask__, tmp__) \ - for (tmp__ = mask__ & INTEL_INFO(dev_priv__)->ring_mask; \ - tmp__ ? (engine__ = (dev_priv__)->engine[__mask_next_bit(tmp__)]), 1 : 0; ) + for ((tmp__) = (mask__) & INTEL_INFO(dev_priv__)->ring_mask; \ + (tmp__) ? ((engine__) = (dev_priv__)->engine[__mask_next_bit(tmp__)]), 1 : 0; )
engine__ is a rhs, it can't have side-effects. Nor tmp__. Doesn't enclosing in () just make the error even more opaque? -Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for drm/i915: Enclose for_each_engine_masked macro arguments in parentheses
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915: Enclose for_each_engine_masked macro arguments in parentheses
URL : https://patchwork.freedesktop.org/series/41261/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip e31cc0477730 drm/i915: Enclose for_each_engine_masked macro arguments in parentheses -:22: ERROR:SPACING: space prohibited before that close parenthesis ')' #22: FILE: drivers/gpu/drm/i915/i915_drv.h:2153: + (tmp__) ? ((engine__) = (dev_priv__)->engine[__mask_next_bit(tmp__)]), 1 : 0; )
total: 1 errors, 0 warnings, 0 checks, 10 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Chris Wilson (2018-04-06 10:29:36)
Quoted 16 lines
Quoting Tvrtko Ursulin (2018-04-06 10:24:17)
Quoted 15 lines
From: Tvrtko Ursulin <[email protected]>
Enclose
for_each_engine_maskedmacro arguments in parentheses.Signed-off-by Tvrtko Ursulin <[email protected]>--- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_drv.h +0
-0@@ -2149,8 +2149,8 @@ static inline struct drm_i915_private *huc_to_i915(struct intel_huc *huc)
Quoted 9 lines
drivers/gpu/drm/i915/i915_drv.h static inline struct drm_i915_private *huc_to_i915(struct intel_huc *huc) · line 2153
Quoted 6 lines
drivers/gpu/drm/i915/i915_drv.h +2
-2/* Iterator over subset of engines selected by mask */ #define for_each_engine_masked (engine__, dev_priv__, mask__, tmp__) \ - for (tmp__ = mask__ & INTEL_INFO(dev_priv__)->ring_mask; \ - tmp__ ? (engine__ = (dev_priv__)->engine[__mask_next_bit(tmp__)]), 1 : 0; ) + for ((tmp__) = (mask__) & INTEL_INFO(dev_priv__)->ring_mask; \ + (tmp__) ? ((engine__) = (dev_priv__)->engine[__mask_next_bit(tmp__)]), 1 : 0; )
engine__is a rhs, it can't have side-effects. Nortmp__. Doesn't enclosing in () just make the error even more opaque?
Lhs. Lhs! I'll be back after coffee.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Enclose for_each_engine_masked macro arguments in parentheses
In reply to PatchworkQuoting Patchwork (2018-04-06 10:29:45)
Quoted 6 lines
== Series Details ==
Series: drm/i915: Enclose
for_each_engine_maskedmacro arguments in parentheses
URL : https://patchwork.freedesktop.org/series/41261/
State : warning
Quoted 7 lines
== Summary ==
$ dim checkpatch origin/drm-tip e31cc0477730 drm/i915: Enclose for_each_engine_masked macro arguments in parentheses -:22: ERROR:SPACING: space prohibited before that close parenthesis ')' #22: FILE: drivers/gpu/drm/i915/i915_drv.h:2153: + (tmp__) ? ((engine__) = (dev_priv__)->engine[__mask_next_bit(tmp__)]), 1 : 0; )
It has no mercy!
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915: Enclose for_each_engine_masked macro arguments in parentheses
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915: Enclose for_each_engine_masked macro arguments in parentheses
URL : https://patchwork.freedesktop.org/series/41261/
State : failure
== Summary ==
Series 41261v1 drm/i915: Enclose for_each_engine_masked macro arguments in parentheses
https://patchwork.freedesktop.org/api/1.0/series/41261/revisions/1/mbox/
---- Possible new issues:
Test gem_exec_flush:
Subgroup basic-uc-pro-default:
pass -> INCOMPLETE (fi-cnl-y3)---- Known issues:
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
pass -> FAIL (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> INCOMPLETE (fi-snb-2520m) fdo#103713
Test prime_vgem:
Subgroup basic-fence-flip:
fail -> PASS (fi-ilk-650) fdo#104008fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:432s fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:444s fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:383s fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:542s fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:298s fi-bxt-dsi total:285 pass:255 dwarn:0 dfail:0 fail:0 skip:30 time:516s fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:517s fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:524s fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:518s fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:411s fi-cfl-s3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:560s fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:512s fi-cnl-y3 total:53 pass:45 dwarn:0 dfail:0 fail:0 skip:7 fi-elk-e7500 total:285 pass:226 dwarn:0 dfail:0 fail:0 skip:59 time:433s fi-gdg-551 total:285 pass:176 dwarn:0 dfail:0 fail:1 skip:108 time:318s fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:543s fi-glk-j4005 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:489s fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:405s fi-ilk-650 total:285 pass:225 dwarn:0 dfail:0 fail:0 skip:60 time:423s fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:475s fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:435s fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:473s fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:463s fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:513s fi-pnv-d510 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:649s fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:446s fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:531s fi-skl-6700k2 total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:503s fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:504s fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:433s fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:446s fi-snb-2520m total:242 pass:208 dwarn:0 dfail:0 fail:0 skip:33 fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:401s
f818c2b87fa1733a6801757f588ca544e105b082 drm-tip: 2018y-04m-06d-07h-06m-57s UTC integration manifest e31cc0477730 drm/i915: Enclose for_each_engine_masked macro arguments in parentheses
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8613/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tvrtko Ursulin
maintainerPATCH v2 1/1 drm/i915: Enclose for_each_engine_masked macro arguments in parentheses
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Enclose for_each_engine_masked macro arguments in parentheses.
v2:
* Fixup whitespace to satisfy checkpatch.
* Likewise reformat to 80 chars.
--- drivers/gpu/drm/i915/i915_drv.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +4 -2
@@ -2149,8 +2149,10 @@ static inline struct drm_i915_private *huc_to_i915(struct intel_huc *huc)/* Iterator over subset of engines selected by mask */ #define for_each_engine_masked (engine__, dev_priv__, mask__, tmp__) \ - for (tmp__ = mask__ & INTEL_INFO(dev_priv__)->ring_mask; \ - tmp__ ? (engine__ = (dev_priv__)->engine[__mask_next_bit(tmp__)]), 1 : 0; ) + for ((tmp__) = (mask__) & INTEL_INFO(dev_priv__)->ring_mask; \ + (tmp__) ? \ + ((engine__) = (dev_priv__)->engine[__mask_next_bit(tmp__)]), 1 : \ + 0;)enum hdmi_force_audio {HDMI_AUDIO_OFF_DVI =-2 ,/* no aux data for HDMI-DVI converter */
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Enclose for_each_engine_masked macro arguments in parentheses (rev2)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915: Enclose for_each_engine_masked macro arguments in parentheses (rev2)
URL : https://patchwork.freedesktop.org/series/41261/
State : success
== Summary ==
Series 41261v2 drm/i915: Enclose for_each_engine_masked macro arguments in parentheses
https://patchwork.freedesktop.org/api/1.0/series/41261/revisions/2/mbox/
---- Known issues:
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-c:
pass -> INCOMPLETE (fi-bxt-dsi) fdo#103927fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:435s fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:442s fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:383s fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:534s fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:299s fi-bxt-dsi total:243 pass:216 dwarn:0 dfail:0 fail:0 skip:26 fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:514s fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:522s fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:508s fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:409s fi-cfl-s3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:562s fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:512s fi-cnl-y3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:582s fi-elk-e7500 total:285 pass:226 dwarn:0 dfail:0 fail:0 skip:59 time:426s fi-gdg-551 total:285 pass:177 dwarn:0 dfail:0 fail:0 skip:108 time:314s fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:538s fi-glk-j4005 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:486s fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:403s fi-ilk-650 total:285 pass:225 dwarn:0 dfail:0 fail:0 skip:60 time:420s fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:469s fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:432s fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:477s fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:459s fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:509s fi-pnv-d510 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:670s fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:442s fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:530s fi-skl-6700k2 total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:501s fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:503s fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:432s fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:448s fi-snb-2520m total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:593s fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:399s
983ee39a4fb441927f2bc64d5874e6c9e585362b drm-tip: 2018y-04m-06d-10h-12m-26s UTC integration manifest b47119c818bc drm/i915: Enclose for_each_engine_masked macro arguments in parentheses
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8618/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Tvrtko Ursulin (2018-04-06 12:44:07)
Quoted 9 lines
From: Tvrtko Ursulin <[email protected]>
Enclose
for_each_engine_maskedmacro arguments in parentheses.v2:
* Fixup whitespace to satisfy checkpatch.
* Likewise reformat to 80 chars.Signed-off-by Tvrtko Ursulin <[email protected]>
Just because the (mask__) does need fixing.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for drm/i915: Enclose for_each_engine_masked macro arguments in parentheses (rev2)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915: Enclose for_each_engine_masked macro arguments in parentheses (rev2)
URL : https://patchwork.freedesktop.org/series/41261/
State : failure
== Summary ==
---- Possible new issues:
Test kms_atomic:
Subgroup plane_invalid_params_fence:
fail -> PASS (shard-snb)
Test kms_atomic_interruptible:
Subgroup legacy-pageflip:
pass -> FAIL (shard-snb)
Test kms_atomic_transition:
Subgroup plane-all-transition-fencing:
fail -> PASS (shard-snb)
Test kms_busy:
Subgroup basic-flip-b:
pass -> SKIP (shard-snb)
Subgroup extended-modeset-hang-newfb-with-reset-render-b:
pass -> FAIL (shard-snb)
Subgroup extended-pageflip-modeset-hang-oldfb-render-b:
fail -> PASS (shard-snb)
Test kms_chv_cursor_fail:
Subgroup pipe-c-128x128-right-edge:
dmesg-warn -> PASS (shard-hsw)
Test kms_cursor_legacy:
Subgroup flip-vs-cursor-busy-crc-atomic:
fail -> PASS (shard-snb)
Subgroup flip-vs-cursor-busy-crc-legacy:
fail -> PASS (shard-snb)
Test kms_draw_crc:
Subgroup draw-method-xrgb2101010-mmap-wc-untiled:
pass -> SKIP (shard-snb)
Test kms_frontbuffer_tracking:
Subgroup fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu:
fail -> SKIP (shard-snb)
Subgroup fbcpsr-2p-scndscrn-cur-indfb-draw-mmap-wc:
skip -> FAIL (shard-snb)
Subgroup fbcpsr-indfb-scaledprimary:
skip -> FAIL (shard-snb)
Subgroup fbcpsr-rgb101010-draw-render:
fail -> SKIP (shard-snb)
Subgroup fbcpsr-slowdraw:
fail -> SKIP (shard-snb)
Subgroup psr-1p-offscren-pri-indfb-draw-pwrite:
fail -> SKIP (shard-snb)
Subgroup psr-1p-primscrn-cur-indfb-draw-mmap-wc:
skip -> FAIL (shard-snb)
Subgroup psr-1p-primscrn-indfb-msflip-blt:
skip -> FAIL (shard-snb)
Subgroup psr-1p-primscrn-pri-shrfb-draw-render:
fail -> SKIP (shard-snb)
Subgroup psr-1p-primscrn-spr-indfb-draw-mmap-wc:
fail -> SKIP (shard-snb)
Subgroup psr-2p-primscrn-cur-indfb-draw-mmap-wc:
fail -> SKIP (shard-snb)
Subgroup psr-2p-primscrn-spr-indfb-move:
fail -> SKIP (shard-snb)
Test kms_plane:
Subgroup pixel-format-pipe-b-planes:
fail -> PASS (shard-snb)
Test kms_properties:
Subgroup connector-properties-atomic:
pass -> FAIL (shard-snb)
Test kms_vblank:
Subgroup pipe-a-ts-continuation-modeset:
pass -> FAIL (shard-snb)
Subgroup pipe-a-ts-continuation-suspend:
fail -> PASS (shard-snb)
Test testdisplay:
warn -> PASS (shard-snb)---- Known issues:
Test gem_fenced_exec_thrash:
Subgroup 2-spare-fences:
dmesg-warn -> PASS (shard-hsw) fdo#102614
Test kms_flip:
Subgroup 2x-plain-flip-ts-check-interruptible:
pass -> FAIL (shard-hsw) fdo#100368 +1
Test kms_frontbuffer_tracking:
Subgroup fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:
fail -> SKIP (shard-snb) fdo#103167 +3
Test kms_sysfs_edid_timing:
warn -> PASS (shard-apl) fdo#100047fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
shard-apl total:2680 pass:1836 dwarn:1 dfail:0 fail:7 skip:836 time:12596s shard-hsw total:2680 pass:1784 dwarn:1 dfail:0 fail:3 skip:891 time:11304s shard-snb total:2680 pass:1370 dwarn:1 dfail:0 fail:12 skip:1297 time:6854s
Blacklisted hosts:
shard-kbl total:2680 pass:1956 dwarn:5 dfail:1 fail:7 skip:711 time:9218s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8618/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx