Skip to contentSkip to conversation

objtool: Support HOSTCFLAGS and HOSTLDFLAGS

PATCH In review Laura Abbott 2 participants 2 messages Apr 11, 2018 – Apr 12, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 objtool: Support HOSTCFLAGS and HOSTLDFLAGS

It may be useful to compile host programs with different flags (e.g. hardening). Ensure that objtool picks up the appropriate flags.

---
v2: Drop several flags that are already defined in HOSTCFLAGS

---
 tools/objtool/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/objtool/Makefile +2 -2
index e6acc281dd37..7df979ae4573 100644
@@ -31,8 +31,8 @@ INCLUDES := -I$(srctree)/tools/include \
 	    -I$(srctree)/tools/arch/$(HOSTARCH)/include/uapi \
 	    -I$(srctree)/tools/objtool/arch/$(ARCH)/include
 WARNINGS := $(EXTRA_WARNINGS) -Wno-switch-default -Wno-switch-enum -Wno-packed
-CFLAGS   += -Wall -Werror $(WARNINGS) -fomit-frame-pointer -O2 -g $(INCLUDES)
-LDFLAGS  += -lelf $(LIBSUBCMD)
+CFLAGS   += -Werror $(WARNINGS) $(HOSTCFLAGS) -g $(INCLUDES)
+LDFLAGS  += -lelf $(LIBSUBCMD) $(HOSTLDFLAGS)
 
 # Allow old libelf to be used:
 elfshdr := $(shell echo '\#include <libelf.h>' | $(CC) $(CFLAGS) -x c -E - | grep elf_getshdr)
Signature · 1 line
2.14.3
#1 lore raw
Quoted 6 lines · Laura Abbott

It may be useful to compile host programs with different flags (e.g. hardening). Ensure that objtool picks up the appropriate flags.

---
v2: Drop several flags that are already defined in HOSTCFLAGS

Thanks Laura. Changes to the objtool makefile usually go through the -tip tree, so I'll run it through some testing and then send it along.

Signature · 1 line
Josh