staging fbtft: Fixed lines exceeding columns limit
Subsystems (2)
PATCH 1/1 staging fbtft: Fixed lines exceeding columns limit
Fix checkpatch.pl warnings of line sizes exceeding 80 columns. Break lines in order to reduce the instructions lengths to less than 80 columns.
--- drivers/staging/fbtft/fbtft-bus.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +9 -4
@@ -22,10 +22,13 @@ void func(struct fbtft_par *par, int len, ...) \if (unlikely (par->debug &DEBUG_WRITE_REGISTER )) { \va_start (args, len); \for (i =0 ; i < len; i++) { \ - buf[i] = modifier((data_type)va_arg(args, unsigned int)); \ + buf[i] =modifier ((data_type )va_arg (args, \ + unsigned int)); \ } \va_end (args); \ -fbtft_par_dbg_hex (DEBUG_WRITE_REGISTER , par, par->info->device, buffer_type, buf, len,"%s: " , __func__); \ +fbtft_par_dbg_hex (DEBUG_WRITE_REGISTER , par, \ + par->info->device, buffer_type, \ + buf, len,"%s: " , __func__); \ } \ \va_start (args, len); \
@@ -37,7 +40,8 @@ void func(struct fbtft_par *par, int len, ...) \ } \ \ *buf = modifier((data_type)va_arg(args, unsigned int)); \ - ret =fbtft_write_buf_dc (par, par->buf,sizeof (data_type) + offset,0 ); \ + ret =fbtft_write_buf_dc (par, par->buf, \ +sizeof (data_type) + offset,0 ); \if (ret <0 ) \ goto out; \ len--; \
@@ -48,7 +52,8 @@ void func(struct fbtft_par *par, int len, ...) \if (len) { \ i = len; \while (i--) \ - *buf++ = modifier((data_type)va_arg(args, unsigned int)); \ + *buf++ =modifier ((data_type )va_arg (args, \ + unsigned int)); \fbtft_write_buf_dc (par, par->buf, \ len * (sizeof (data_type) + offset),1 ); \ } \
Signature · 6 lines
2.7.4 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
drivers/staging/fbtft/fbtft-bus.c void func(struct fbtft_par *par, int len, ...) \ · line 26
Quoted 6 lines
drivers/staging/fbtft/fbtft-bus.c +2
-1if (unlikely (par->debug &DEBUG_WRITE_REGISTER )) { \va_start (args, len); \for (i =0 ; i < len; i++) { \ - buf[i] = modifier((data_type)va_arg(args, unsigned int)); \ + buf[i] =modifier ((data_type )va_arg (args, \ + unsigned int)); \
Normally we'd align the parameters like so:
buf[i] = modifier((data_type)va_arg(args, \ unsigned int)); \
drivers/staging/fbtft/fbtft-bus.c void func(struct fbtft_par *par, int len, ...) \ · line 32
Quoted 7 lines
drivers/staging/fbtft/fbtft-bus.c +3
-1} \va_end (args); \ -fbtft_par_dbg_hex (DEBUG_WRITE_REGISTER , par, par->info->device, buffer_type, buf, len,"%s: " , __func__); \ +fbtft_par_dbg_hex (DEBUG_WRITE_REGISTER , par, \ + par->info->device, buffer_type, \ + buf, len,"%s: " , __func__); \ } \
Not properly aligned.
drivers/staging/fbtft/fbtft-bus.c void func(struct fbtft_par *par, int len, ...) \ · line 40
Quoted 7 lines
drivers/staging/fbtft/fbtft-bus.c +0
-1\va_start (args, len); \@@ -37,7 +40,8 @@ void func(struct fbtft_par *par, int len, ...) \ } \ \ *buf = modifier((data_type)va_arg(args, unsigned int)); \ - ret =fbtft_write_buf_dc (par, par->buf,sizeof (data_type) + offset,0 ); \
I feel like the original is basically OK but if we're going to change it then align it like this:
ret = fbtft_write_buf_dc(par, par->buf, sizeof(data_type) + offset, \ 0); \
Etc.
regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Quoted 11 lines · Dan Carpenter
drivers/staging/fbtft/fbtft-bus.c void func(struct fbtft_par *par, int len, ...) \ · line 40
Quoted 1 line
drivers/staging/fbtft/fbtft-bus.c +0
-1- ret =fbtft_write_buf_dc (par, par->buf,sizeof (data_type) + offset,0 ); \I feel like the original is basically OK but if we're going to change it then align it like this:
ret = fbtft_write_buf_dc(par, par->buf, sizeof(data_type) + offset, \ 0); \Etc.
Alright, I'll fix this issue then send another email with the fixed patch.
Thanks!
renato
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel