fs: iomap: Change return type to vm_fault_t
Subsystems (2)
PATCH 1/1 fs: iomap: Change return type to vm_fault_t
Return type has been changed for iomap_page_mkwrite().
--- fs/iomap.c | 2 +- include/linux/iomap.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-)
fs/iomap.c +1 -1
@@ -443,7 +443,7 @@ static int iomap_dax_zero(loff_t pos, unsigned offset, unsigned bytes,return length; } -int iomap_page_mkwrite (struct vm_fault *vmf,const struct iomap_ops *ops) +vm_fault_t iomap_page_mkwrite (struct vm_fault *vmf,const struct iomap_ops *ops) {struct page *page = vmf->page;struct inode *inode =file_inode (vmf->vma->vm_file);
include/linux/iomap.h +3 -1
@@ -3,6 +3,7 @@#define LINUX_IOMAP_H 1#include <linux/types.h> +#include <linux/mm_types.h> struct fiemap_extent_info ;struct inode ;
@@ -88,7 +89,8 @@ int iomap_zero_range(struct inode *inode, loff_t pos, loff_t len, bool *did_zero, const struct iomap_ops *ops);int iomap_truncate_page (struct inode *inode,loff_t pos,bool *did_zero,const struct iomap_ops *ops); -int iomap_page_mkwrite (struct vm_fault *vmf,const struct iomap_ops *ops); +vm_fault_t iomap_page_mkwrite (struct vm_fault *vmf, +const struct iomap_ops *ops);int iomap_fiemap (struct inode *inode,struct fiemap_extent_info *fieinfo,loff_t start,loff_t len,const struct iomap_ops *ops); loff_t iomap_seek_hole(struct inode *inode, loff_t offset,
Signature · 1 line
1.9.1
Quoted 45 lines · Souptick Joarder
Return type has been changed for
iomap_page_mkwrite().Signed-off-by Souptick Joarder <[email protected]>Reviewed-by Matthew Wilcox <[email protected]>--- fs/iomap.c | 2 +- include/linux/iomap.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-)fs/iomap.c +1
-1@@ -443,7 +443,7 @@ static int iomap_dax_zero(loff_t pos, unsigned offset, unsigned bytes,return length; } -int iomap_page_mkwrite (struct vm_fault *vmf,const struct iomap_ops *ops) +vm_fault_t iomap_page_mkwrite (struct vm_fault *vmf,const struct iomap_ops *ops) {struct page *page = vmf->page;struct inode *inode =file_inode (vmf->vma->vm_file);include/linux/iomap.h +3
-2@@ -3,6 +3,7 @@#define LINUX_IOMAP_H 1#include <linux/types.h> +#include <linux/mm_types.h> struct fiemap_extent_info ;struct inode ;@@ -88,7 +89,8 @@ int iomap_zero_range(struct inode *inode, loff_t pos, loff_t len, bool *did_zero, const struct iomap_ops *ops);int iomap_truncate_page (struct inode *inode,loff_t pos,bool *did_zero,const struct iomap_ops *ops); -int iomap_page_mkwrite (struct vm_fault *vmf,const struct iomap_ops *ops); +vm_fault_t iomap_page_mkwrite (struct vm_fault *vmf, +const struct iomap_ops *ops);int iomap_fiemap (struct inode *inode,struct fiemap_extent_info *fieinfo,loff_t start,loff_t len,const struct iomap_ops *ops); loff_t iomap_seek_hole(struct inode *inode, loff_t offset, --
Quoted 2 lines
1.9.1
Any further comment on this patch ? We would like to get this patch in queue for 4.18.
Quoted 2 lines · Souptick Joarder
Any further comment on this patch ? We would like to get this patch in queue for 4.18.
NAK. This is coplete churn. As said before a proper type for VM faults might be useful, but random patches that change bits around aren't.
Please send out the whole picture instead of artifially inflating your commit count while making everyone elses life harder.
Quoted 6 lines · Christoph Hellwig
Quoted 2 lines · Souptick Joarder
Any further comment on this patch ? We would like to get this patch in queue for 4.18.
NAK. This is coplete churn. As said before a proper type for VM faults might be useful, but random patches that change bits around aren't.
Not exactly cause we are sending patches in proper planned way after introducing commit 1c8f422059ae ("mm: change return type to vm_fault_t") in 4.17-rc1. Except few patches, most of the patches already finds their way in different maintainers -next tree as well as in linux-next tree.