trace: add missing forward declaration
PATCH 1/1 trace: add missing forward declaration
Without this forward declaration compile may fail if this header is included only for registering other probe event without struct pool_workqueue.
--- include/trace/events/workqueue.h | 2 ++ 1 file changed, 2 insertions(+)
include/trace/events/workqueue.h +2 -0
@@ -25,6 +25,8 @@ DECLARE_EVENT_CLASS(workqueue_work,TP_printk ("work struct %p" , __entry->work) ); +struct pool_workqueue ; +/** * workqueue_queue_work - called when a work gets queued * @req_cpu: the requested cpu
Signature · 1 line
2.17.0.484.g0c8726318c-goog
Steven Rostedt
maintainerQuoted 4 lines · On Mon, 16 Apr 2018 10:36:25 +0800 Ahbong Chang <[email protected]> wrote:
Without this forward declaration compile may fail if this header is included only for registering other probe event without struct
pool_workqueue.
Is this for new work or is there a config which this fails with today?
-- Steve
Quoted 19 lines
Signed-off-by Ahbong Chang <[email protected]>Reviewed-by Todd Poynor <[email protected]>--- include/trace/events/workqueue.h | 2 ++ 1 file changed, 2 insertions(+)include/trace/events/workqueue.h +2
-0@@ -25,6 +25,8 @@ DECLARE_EVENT_CLASS(workqueue_work,TP_printk ("work struct %p" , __entry->work) ); +struct pool_workqueue ; +/** * workqueue_queue_work - called when a work gets queued * @req_cpu: the requested cpu
It does not fail with any config without this fix. This is for new work.
-- Ahbong
Quoted 12 lines · Steven Rostedt
Quoted 4 lines · On Mon, 16 Apr 2018 10:36:25 +0800 Ahbong Chang <[email protected]> wrote:
Without this forward declaration compile may fail if this header is included only for registering other probe event without struct
pool_workqueue.Is this for new work or is there a config which this fails with today?
-- Steve
Quoted 7 lines
Review
Quoted 7 lines
Signed-off-by Ahbong Chang <[email protected]>Reviewed-by Todd Poynor <[email protected]>--- include/trace/events/workqueue.h | 2 ++ 1 file changed, 2 insertions(+)(quoted diff) +0
-0
b/include/trace/events/workqueue.h
Quoted 12 lines
Quoted 12 lines
index
2f057a494d93..9a761bc6a251100644include/trace/events/workqueue.h +2
-0@@ -25,6 +25,8 @@ DECLARE_EVENT_CLASS(workqueue_work,TP_printk ("work struct %p" , __entry->work) ); +struct pool_workqueue ; +/** * workqueue_queue_work - called when a work gets queued * @req_cpu: the requested cpu
Quoted 1 line · Ahbong Chang
It does not fail with any config without this fix. This is for new work.
Then why not submit it as part of the "new work" patch series? That's how dependancies are normally handled.
thanks,
greg k-h
The new work series are not ready yet. I think this patch does make the source better so here is the small patch alone.
-- Ahbong
Quoted 9 lines · Greg Kroah-Hartman
Quoted 1 line · Ahbong Chang
It does not fail with any config without this fix. This is for new work.
Then why not submit it as part of the "new work" patch series? That's how dependancies are normally handled.
thanks,
greg k-h
Steven Rostedt
maintainerQuoted 5 lines · On Tue, 17 Apr 2018 12:29:09 +0200 Greg Kroah-Hartman…
Quoted 1 line · Ahbong Chang
It does not fail with any config without this fix. This is for new work.
Then why not submit it as part of the "new work" patch series? That's how dependancies are normally handled.
I consider this patch making the kernel more robust. The reason I asked was to know if it should be marked for stable or not. If nothing currently relies on it, I just put it into the -rc as a "make the kernel a little more robust" change. If other code relies on it, I mark it for stable.
I'll take this patch as more of a clean up.
Thanks!
-- Steve