drm/i915: Remove skl dc6 enable/disable functions
Subsystems (2)
PATCH 1/1 drm/i915: Remove skl dc6 enable/disable functions
One is outright unused, other can be made static.
Drive-by cleanup while accidentally reading dc code.
Cc. Dhinakaran Pandiyan <[email protected]>
--- drivers/gpu/drm/i915/intel_drv.h | 2 -- drivers/gpu/drm/i915/intel_runtime_pm.c | 14 +------------- 2 files changed, 1 insertion(+), 15 deletions(-)
drivers/gpu/drm/i915/intel_drv.h +0 -2
@@ -1580,8 +1580,6 @@ void bxt_enable_dc9(struct drm_i915_private *dev_priv);void bxt_disable_dc9 (struct drm_i915_private *dev_priv);void gen9_enable_dc5 (struct drm_i915_private *dev_priv);unsigned int skl_cdclk_get_vco (unsigned int freq); -void skl_enable_dc6 (struct drm_i915_private *dev_priv); -void skl_disable_dc6 (struct drm_i915_private *dev_priv);void intel_dp_get_m_n (struct intel_crtc *crtc,struct intel_crtc_state *pipe_config);void intel_dp_set_m_n (struct intel_crtc *crtc,enum link_m_n_set m_n);
drivers/gpu/drm/i915/intel_runtime_pm.c +1 -13
@@ -635,7 +635,7 @@ static void assert_can_enable_dc6(struct drm_i915_private *dev_priv)assert_csr_loaded (dev_priv); } -void skl_enable_dc6 (struct drm_i915_private *dev_priv) +static void skl_enable_dc6 (struct drm_i915_private *dev_priv) {assert_can_enable_dc6 (dev_priv);
@@ -645,18 +645,6 @@ void skl_enable_dc6(struct drm_i915_private *dev_priv) } -void skl_disable_dc6 (struct drm_i915_private *dev_priv) -{ -DRM_DEBUG_KMS ("Disabling DC6\n" ); - -/* Wa Display #1183: skl,kbl,cfl */ -if (IS_GEN9_BC (dev_priv)) -I915_WRITE (GEN8_CHICKEN_DCPR_1 ,I915_READ (GEN8_CHICKEN_DCPR_1 ) | -SKL_SELECT_ALTERNATE_DC_EXIT ); - -gen9_set_dc_state (dev_priv,DC_STATE_DISABLE ); -} -static void hsw_power_well_sync_hw (struct drm_i915_private *dev_priv,struct i915_power_well *power_well) {
Signature · 6 lines
2.16.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Remove skl dc6 enable/disable functions
== Series Details ==
== Series Details ==
Series: drm/i915: Remove skl dc6 enable/disable functions
URL : https://patchwork.freedesktop.org/series/41803/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4059 -> Patchwork_8704 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/41803/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_8704 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-ivb-3520m: PASS -> DMESG-WARN (fdo#106084)
fi-bxt-dsi: PASS -> INCOMPLETE (fdo#103927)
==== Possible fixes ====
igt@gem_mmap_gtt@basic-small-bo-tiledx:
fi-gdg-551: FAIL (fdo#102575) -> PASS
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
fi-elk-e7500: INCOMPLETE (fdo#103989) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-ivb-3520m: DMESG-WARN (fdo#106084) -> PASS fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084
== Participating hosts (36 -> 33) ==
Missing (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4059 -> Patchwork_8704
CI_DRM_4059: c1645edc253f2b52a8c94565a75b479a6782e75f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4435: ddbe5a4d8bb1780ecf07f72e815062d3bce8ff71 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8704: cadfa04c6ef9b6d841f5115a415a34cb82f8af06 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4435: e60d247eb359f044caf0c09904da14e39d7adca1 @ git://anongit.freedesktop.org/piglit
== Linux commits ==
cadfa04c6ef9 drm/i915: Remove skl dc6 enable/disable functions
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8704/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: Remove skl dc6 enable/disable functions
In reply to Daniel Vetter== Series Details ==
== Series Details ==
Series: drm/i915: Remove skl dc6 enable/disable functions
URL : https://patchwork.freedesktop.org/series/41803/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4059_full -> Patchwork_8704_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_8704_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_8704_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/41803/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_8704_full:
=== IGT changes ===
==== Warnings ====
igt@gem_mocs_settings@mocs-rc6-vebox:
shard-kbl: PASS -> SKIP== Known issues ==
Here are the changes found in Patchwork_8704_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_workarounds@suspend-resume-context:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@kms_flip@2x-modeset-vs-vblank-race:
shard-hsw: PASS -> FAIL (fdo#103060)
igt@kms_flip@2x-plain-flip-fb-recreate:
shard-hsw: PASS -> FAIL (fdo#100368)
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-hsw: FAIL (fdo#102887) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-apl: FAIL (fdo#102887, fdo#105363) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 4) ==
Missing (2): shard-glk shard-glkb
== Build changes ==
* Linux: CI_DRM_4059 -> Patchwork_8704
CI_DRM_4059: c1645edc253f2b52a8c94565a75b479a6782e75f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4435: ddbe5a4d8bb1780ecf07f72e815062d3bce8ff71 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8704: cadfa04c6ef9b6d841f5115a415a34cb82f8af06 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4435: e60d247eb359f044caf0c09904da14e39d7adca1 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8704/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✓ Fi.CI.IGT: success for drm/i915: Remove skl dc6 enable/disable functions
Quoted 5 lines · Patchwork
== Series Details ==
Series: drm/i915: Remove skl dc6 enable/disable functions
URL : https://patchwork.freedesktop.org/series/41803/
State : success
Thanks for the patch, pushed it to -dinq.
Quoted 80 lines
== Summary ==
= CI Bug Log - changes from
CI_DRM_4059_full->Patchwork_8704_full=== Summary - WARNING ==
Minor unknown changes coming with
Patchwork_8704_fullneed to be verified manually.If you think the reported changes have nothing to do with the changes introduced in
Patchwork_8704_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.External URL: https://patchwork.freedesktop.org/api/1.0/series/41803/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in
Patchwork_8704_full:=== IGT changes ===
==== Warnings ==== igt@gem_mocs_settings@mocs-rc6-vebox: shard-kbl: PASS -> SKIP== Known issues ==
Here are the changes found in
Patchwork_8704_fullthat come from known issues:=== IGT changes ===
==== Issues hit ==== igt@gem_workarounds@suspend-resume-context: shard-kbl: PASS -> INCOMPLETE (fdo#103665) igt@kms_flip@2x-modeset-vs-vblank-race: shard-hsw: PASS -> FAIL (fdo#103060) igt@kms_flip@2x-plain-flip-fb-recreate: shard-hsw: PASS -> FAIL (fdo#100368) igt@kms_setmode@basic: shard-kbl: PASS -> FAIL (fdo#99912) ==== Possible fixes ==== igt@kms_flip@2x-flip-vs-expired-vblank: shard-hsw: FAIL (fdo#102887) -> PASS igt@kms_flip@flip-vs-expired-vblank-interruptible: shard-apl: FAIL (fdo#102887, fdo#105363) -> PASSfdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912== Participating hosts (6 -> 4) ==
Missing (2): shard-glk shard-glkb
== Build changes ==
* Linux:
CI_DRM_4059->Patchwork_8704
CI_DRM_4059:c1645edc253f2b52a8c94565a75b479a6782e75f@git://anongit.freedesktop.org/gfx-ci/linux
IGT_4435:ddbe5a4d8bb1780ecf07f72e815062d3bce8ff71@git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8704:cadfa04c6ef9b6d841f5115a415a34cb82f8af06@git://anongit.freedesktop.org/gfx-ci/linux
piglit_4435:e60d247eb359f044caf0c09904da14e39d7adca1@git://anongit.freedesktop.org/piglit
Quoted 7 lines
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8704/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx