USB: renesas_usbhs: drop support for legacy phys

PATCH New Johan Hovold 1 participant 1 message Apr 18, 2018 USB

lore

Share & tools

lore

Johan Hovold

author

2018-04-18 08:42 UTC #0 lore raw

PATCH 5/6 USB: renesas_usbhs: drop support for legacy phys

Quoted 16 lines · Yoshihiro Shimoda

Hi,
Quoted 8 lines
From: Johan Hovold, Sent: Saturday, April 14, 2018 10:06 PM
Drop support for legacy phys which hasn't been used with a mainline kernel since commit 9080b8dc761a ("ARM: OMAP2+: Remove legacy usb-host.c platform init code"). Specifically, since that commit usb_get_phy_dev() have always returned -ENODEV and consequently this code has not been used.
Quoted 5 lines
Signed-off-by Johan Hovold <[email protected]>
---
 drivers/usb/renesas_usbhs/common.h |  1 -
 drivers/usb/renesas_usbhs/rcar2.c  | 29 -----------------------------
 2 files changed, 30 deletions(-)

Quoted 6 lines

Thank you for the patch!
The drivers/usb/renesas_usbhs/mod_gadget.c still uses the legacy phy API (usb_get_phy()).
Also this patch set doesn't drop the API. So, I think this subject should be changed.
What do you think?

Good point, I'll try to rephrase it.

How about

USB: renesas_usbhs: drop unused legacy-phy support

and then I amend the commit message with a note about the legacy API still being used in gadget mode to bind the peripheral controller?

Quoted 1 line

Dropping usb_get_phy_dev() from this driver is good to me.

Thanks,
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html