Skip to contentSkip to conversation

USB: ehci-omap: drop unused legacy phy support

PATCH New Johan Hovold 1 participant 1 message Apr 18, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 3/6 USB: ehci-omap: drop unused legacy phy support

Drop support for looking up legacy phys defined by board files, something which hasn't been used by a mainline kernel since commit 9080b8dc761a ("ARM: OMAP2+: Remove legacy usb-host.c platform init code"). Specifically, since that commit usb_get_phy_dev() have always returned -ENODEV and consequently this code has not been used.

---
 drivers/usb/host/ehci-omap.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/usb/host/ehci-omap.c +1 -4
index 8d8bafc70c1f..7e4c13346a1e 100644
@@ -157,10 +157,7 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
 		struct usb_phy *phy;
 
 		/* get the PHY device */
-		if (dev->of_node)
-			phy = devm_usb_get_phy_by_phandle(dev, "phys", i);
-		else
-			phy = devm_usb_get_phy_dev(dev, i);
+		phy = devm_usb_get_phy_by_phandle(dev, "phys", i);
 		if (IS_ERR(phy)) {
 			/* Don't bail out if PHY is not absolutely necessary */
 			if (pdata->port_mode[i] != OMAP_EHCI_PORT_MODE_PHY)