ASoC: dai playback_active and capture_active may be greater than 1
RFC PATCH 1/1 ASoC: dai playback_active and capture_active may be greater than 1
At the moment playback_active and capture_active are using only 1 bit so the maximum active count is 1.
However, snd_soc_runtime_activate() may be called several time on the same dai. This happens when a dai is part of several dai_links. It is often the case for "snd-soc-dummy-dai".
This is a problem if snd_soc_runtime_activate() is called an even number of times on a dai. In this case the active count overflow back to 0. As consequence, ASoC functions, such as soc_dpcm_runtime_update(), won't run correctly.
Storing these usage counts on plain 'unsigned int' solves the problem.
---
Hi,
I found this problem while working on ASoC support for a new platform. During a playback, using DPCM, if I changed the backend dai, nothing happened, old backend path was not pruned, new backend path was not added.
Here is how it goes:
1 FE and 2 BE, all 3 using snd-soc-dummy-dai for the codec_dai (ATM).
On playback start:
- BE #1 activates and increments snd-soc-dummy-dai's playback_active
- FE activates and increments snd-soc-dummy-dai's playback_active
The playback works but snd-soc-dummy-dai's playback_active value is now 0.
Through a mux kcontrol, change BE client of FE, from BE #1 to BE #2.
-> trigger soc_dpcm_runtime_update().
-> checks fe's codec_dai playback_active which is zero so playback path processing is skipped, keeping the old invalid path.
include/sound/soc-dai.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/sound/soc-dai.h +2 -2
@@ -294,8 +294,8 @@ struct snd_soc_dai {struct snd_soc_dai_driver *driver;/* DAI runtime info */ - unsigned int capture_active:1; /* stream is in use */ - unsigned int playback_active:1; /* stream is in use */ +unsigned int capture_active;/* stream usage count */ +unsigned int playback_active;/* stream usage count */ unsigned int probed:1;unsigned int active;
Signature · 1 line
2.14.3
Quoted 12 lines · Jerome Brunet
At the moment
playback_activeandcapture_activeare using only 1 bit so the maximum active count is 1.However,
snd_soc_runtime_activate()may be called several time on the same dai. This happens when a dai is part of severaldai_links. It is often the case for "snd-soc-dummy-dai".This is a problem if
snd_soc_runtime_activate()is called an even number of times on a dai. In this case the active count overflow back to 0. As consequence, ASoC functions, such assoc_dpcm_runtime_update(), won't run correctly.
Quoted 5 lines
Storing these usage counts on plain 'unsigned int' solves the problem.
Fixes f0fba2ad1b6b ("ASoC: multi-component - ASoC Multi-Component Support")Signed-off-by Jerome Brunet <[email protected]>---
Thanks,
Charles
Mark Brown
maintainerApplied "ASoC: dai playback and capture active may be greater than 1" to the asoc tree
In reply to Jerome BrunetThe patch
ASoC: dai playback and capture active may be greater than 1
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
40c57963789d451c26269e3bc9f9e803060fd9afMon Sep 17 00:00:00 2001
From: Jerome Brunet <[email protected]>
Date: Fri, 27 Apr 2018 13:31:51 +0200
Subject: [PATCH] ASoC: dai playback and capture active may be greater than 1
At the moment playback_active and capture_active are using only 1 bit so the maximum active count is 1.
However, snd_soc_runtime_activate() may be called several time on the same dai. This happens when a dai is part of several dai_links. It is often the case for "snd-soc-dummy-dai".
This is a problem if snd_soc_runtime_activate() is called an even number of times on a dai. In this case the active count overflow back to 0. As consequence, ASoC functions, such as soc_dpcm_runtime_update(), won't run correctly.
Storing these usage counts on plain 'unsigned int' solves the problem.
--- include/sound/soc-dai.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/sound/soc-dai.h +2 -2
@@ -294,8 +294,8 @@ struct snd_soc_dai {struct snd_soc_dai_driver *driver;/* DAI runtime info */ - unsigned int capture_active:1; /* stream is in use */ - unsigned int playback_active:1; /* stream is in use */ +unsigned int capture_active;/* stream usage count */ +unsigned int playback_active;/* stream usage count */ unsigned int probed:1;unsigned int active;
Signature · 1 line
2.17.0