Skip to contentSkip to conversation

regulator: tps6586x: Add support for TPS658624

PATCH In review ryang 3 participants 4 messages Apr 19, 2018 – Apr 20, 2018

Subsystems (2)
Multifunction devices (MFD) Voltage and current regulator framework
lore
Share & tools
lore

ryang

author
#0 lore raw

PATCH 1/1 regulator: tps6586x: Add support for TPS658624

This version is exists in the Samsung Galaxy Tab 10.1 which is based on the Nvidia Tegra 2 board. The TPS658624 has the same SM2 voltage table as TPS658623.

Signed-off-by ryang <[email protected]>
---
 drivers/regulator/tps6586x-regulator.c | 1 +
 include/linux/mfd/tps6586x.h           | 1 +
 2 files changed, 2 insertions(+)
drivers/regulator/tps6586x-regulator.c +1 -0
index 9e9d220..ba3dae7 100644
@@ -342,6 +342,7 @@ static struct tps6586x_regulator *find_regulator_info(int id, int version)
 
 	switch (version) {
 	case TPS658623:
+	case TPS658624:
 		table = tps658623_regulator;
 		num = ARRAY_SIZE(tps658623_regulator);
 		break;
include/linux/mfd/tps6586x.h +1 -0
index 2fe68e4..b19c280 100644
@@ -18,6 +18,7 @@
 #define TPS658621A	0x15
 #define TPS658621CD	0x2c
 #define TPS658623	0x1b
+#define TPS658624	0x0a
 #define TPS658640	0x01
 #define TPS658640v2	0x02
 #define TPS658643	0x03
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 9 lines · ryang

This version is exists in the Samsung Galaxy Tab 10.1 which is based on the Nvidia Tegra 2 board. The TPS658624 has the same SM2 voltage table as TPS658623.

Signed-off-by ryang <[email protected]>
---
 drivers/regulator/tps6586x-regulator.c | 1 +
 include/linux/mfd/tps6586x.h           | 1 +
 2 files changed, 2 insertions(+)

This also touches the MFD header for the part so should've been sent to Lee, the MFD maintainer (CCed here, left the entire patch for context).

Quoted 27 lines
drivers/regulator/tps6586x-regulator.c +1 -0
index 9e9d220..ba3dae7 100644
@@ -342,6 +342,7 @@ static struct tps6586x_regulator *find_regulator_info(int id, int version)
 
 	switch (version) {
 	case TPS658623:
+	case TPS658624:
 		table = tps658623_regulator;
 		num = ARRAY_SIZE(tps658623_regulator);
 		break;
include/linux/mfd/tps6586x.h +1 -0
index 2fe68e4..b19c280 100644
@@ -18,6 +18,7 @@
 #define TPS658621A	0x15
 #define TPS658621CD	0x2c
 #define TPS658623	0x1b
+#define TPS658624	0x0a
 #define TPS658640	0x01
 #define TPS658640v2	0x02
 #define TPS658643	0x03
Signature · 1 line
2.7.4
Acked-by
#2 lore raw
Quoted 5 lines · Mark Brown
Quoted 3 lines · ryang

This version is exists in the Samsung Galaxy Tab 10.1 which is based on the Nvidia Tegra 2 board. The TPS658624 has the same SM2 voltage table as TPS658623.

Quoted 8 lines
Quoted 5 lines
Signed-off-by ryang <[email protected]>
---
 drivers/regulator/tps6586x-regulator.c | 1 +
 include/linux/mfd/tps6586x.h           | 1 +
 2 files changed, 2 insertions(+)

This also touches the MFD header for the part so should've been sent to Lee, the MFD maintainer (CCed here, left the entire patch for context).

Thanks Mark.

Please take it.

Acked-by Lee Jones <[email protected]>
Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
maintainer
#3 lore raw

Applied "regulator: tps6586x: Add support for TPS658624" to the regulator tree

In reply to ryang

The patch

regulator: tps6586x: Add support for TPS658624

has been applied to the regulator tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 669ca0303ac93adba0e046d414165250861efdb7 Mon Sep 17 00:00:00 2001

From: ryang <[email protected]>
Date: Thu, 19 Apr 2018 12:18:50 -0400
Subject: [PATCH] regulator: tps6586x: Add support for TPS658624

This version is exists in the Samsung Galaxy Tab 10.1 which is based on the Nvidia Tegra 2 board. The TPS658624 has the same SM2 voltage table as TPS658623.

Signed-off-by ryang <[email protected]>
Acked-by Lee Jones <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 drivers/regulator/tps6586x-regulator.c | 1 +
 include/linux/mfd/tps6586x.h           | 1 +
 2 files changed, 2 insertions(+)
drivers/regulator/tps6586x-regulator.c +1 -0
index 9e9d22038017..ba3dae7b2d2d 100644
@@ -342,6 +342,7 @@ static struct tps6586x_regulator *find_regulator_info(int id, int version)
 
 	switch (version) {
 	case TPS658623:
+	case TPS658624:
 		table = tps658623_regulator;
 		num = ARRAY_SIZE(tps658623_regulator);
 		break;
include/linux/mfd/tps6586x.h +1 -0
index 2fe68e481230..b19c2801a30e 100644
@@ -18,6 +18,7 @@
 #define TPS658621A	0x15
 #define TPS658621CD	0x2c
 #define TPS658623	0x1b
+#define TPS658624	0x0a
 #define TPS658640	0x01
 #define TPS658640v2	0x02
 #define TPS658643	0x03
Signature · 1 line
2.17.0