media: vpbe_venc: potential uninitialized variable in ven_sub_dev_init()

PATCH New Dan Carpenter 1 participant 1 message Apr 20, 2018

Subsystems (2)

Media (V4L/DVB) Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2018-04-20 10:13 UTC #0 lore raw

PATCH 1/1 media: vpbe_venc: potential uninitialized variable in ven_sub_dev_init()

Smatch complains that "venc" could be unintialized. There a couple error paths where it looks like maybe that could happen. I don't know if it's really a bug, but it's reasonable to set "venc" to NULL and silence the warning.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/platform/davinci/vpbe_venc.c +1 -1

index 5c255de3b3f8..ba157827192c 100644
@@ -606,7 +606,7 @@ static int venc_device_get(struct device *dev, void *data)
 struct v4l2_subdev *venc_sub_dev_init(struct v4l2_device *v4l2_dev,
 		const char *venc_name)
 {
-	struct venc_state *venc;
+	struct venc_state *venc = NULL;
 
 	bus_for_each_dev(&platform_bus_type, NULL, &venc,
 			venc_device_get);