Skip to contentSkip to conversation

lib: avoid soft lockup in test_find_first_bit()

PATCH New Yury Norov 1 participant 1 message Apr 20, 2018

Subsystems (2)
lore
Share & tools
lore

Yury Norov

author
#0 lore raw

PATCH 1/1 lib: avoid soft lockup in test_find_first_bit()

test_find_first_bit() is intentionally sub-optimal,
and may cause soft lockup due to long time of run on some systems. So decrease length of bitmap to traverse to avoid lockup.

With the change below, time of test execution doesn't exceed 0.2 seconds on my testing system.

Fixes 4441fca0a27f5 ("lib: test module for find_*_bit() functions")
---
 lib/find_bit_benchmark.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
lib/find_bit_benchmark.c +6 -1
index 5985a25e6cbc..5367ffa5c18f 100644
@@ -132,7 +132,12 @@ static int __init find_bit_test(void)
 	test_find_next_bit(bitmap, BITMAP_LEN);
 	test_find_next_zero_bit(bitmap, BITMAP_LEN);
 	test_find_last_bit(bitmap, BITMAP_LEN);
-	test_find_first_bit(bitmap, BITMAP_LEN);
+
+	/*
+	 * test_find_first_bit() may take some time, so
+	 * traverse only part of bitmap to avoid soft lockup.
+	 */
+	test_find_first_bit(bitmap, BITMAP_LEN / 10);
 	test_find_next_and_bit(bitmap, bitmap2, BITMAP_LEN);
 
 	pr_err("\nStart testing find_bit() with sparse bitmap\n");
Signature · 1 line
2.14.1