Skip to contentSkip to conversation

usb:serial:optrion: fix dwm-158 3g modem interface

DISCUSSION Johan Hovold 1 participant 1 message Apr 23, 2018 USB

lore
Share & tools
lore
#0 lore raw
Quoted 28 lines · Lars Melin
Quoted 15 lines · Giuseppe Lippolis

The dwm-158 interface 4 and 5 doesn't answer to the AT commands and doesn't appears a option interface.
Tested on openwrt distribution (kernel 4.14 using the old blacklist definitions).

---
  drivers/usb/serial/option.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/serial/option.c +0 -0
index c3f252283ab9..f0c3612467a3 100644

drivers/usb/serial/option.c static const struct usb_device_id option_ids[] = { · line 1918

Quoted 9 lines
drivers/usb/serial/option.c +2 -1
@@ -1911,7 +1911,8 @@ static const struct usb_device_id option_ids[] = {
  	{ USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7d01, 0xff) },			/* D-Link DWM-156 (variant) */
  	{ USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7d02, 0xff) },
  	{ USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7d03, 0xff) },
-	{ USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7d04, 0xff) },			/* D-Link DWM-158 */
+	{ USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7d04, 0xff),			/* D-Link DWM-158 */
+	 .driver_info = RSVD(4) | RSVD(5) },
  	{ USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7d0e, 0xff) },			/* D-Link DWM-157 C1 */
  	{ USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e19, 0xff),			/* D-Link DWM-221 B1 */
  	  .driver_info = RSVD(4) },

Blacklisting interface 4 and 5 is correct because:

Quoted 6 lines

MI_00 D-Link Mobile Broadband Device (cdc_ether)
MI_02 D-Link HSPA+DataCard Diagnostics Interface (also ppp modem) MI_03 D-Link HSPA+DataCard NMEA Device
MI_04 D-Link HSPA+DataCard Speech Port
MI_05 D-Link HSPA+DataCard Debug Port
MI_06 USB Mass Storage Device

Thanks to both of you. I added Lars's comment to the commit message before applying.

Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html