gpu: host1x: Fix dma_free_wc() argument in the error path
PATCH 1/1 gpu: host1x: Fix dma_free_wc() argument in the error path
If IOVA allocation or IOMMU mapping fails, dma_free_wc() is invoked with size=0 because of a typo, that triggers "kernel BUG at mm/vmalloc.c:124!".
Signed-off-by Dmitry Osipenko <[email protected]>
--- drivers/gpu/host1x/cdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/host1x/cdma.c +1 -1
@@ -127,7 +127,7 @@ static int host1x_pushbuffer_init(struct push_buffer *pb) iommu_free_iova:__free_iova (&host1x->iova, alloc); iommu_free_mem: -dma_free_wc (host1x->dev, pb->alloc_size, pb->mapped, pb->phys); +dma_free_wc (host1x->dev, size, pb->mapped, pb->phys);return err; }
Signature · 1 line
2.17.0
Reviewed-by Mikko Perttunen <[email protected]>
Quoted 22 lines · Dmitry Osipenko
If IOVA allocation or IOMMU mapping fails,
dma_free_wc()is invoked with size=0 because of a typo, that triggers "kernel BUG atmm/vmalloc.c:124!".Signed-off-by Dmitry Osipenko <[email protected]>--- drivers/gpu/host1x/cdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/host1x/cdma.c +1
-1@@ -127,7 +127,7 @@ static int host1x_pushbuffer_init(struct push_buffer *pb) iommu_free_iova:__free_iova (&host1x->iova, alloc); iommu_free_mem: -dma_free_wc (host1x->dev, pb->alloc_size, pb->mapped, pb->phys); +dma_free_wc (host1x->dev, size, pb->mapped, pb->phys);return err; }
Thierry Reding
AppliedQuoted 7 lines · Dmitry Osipenko
If IOVA allocation or IOMMU mapping fails,
dma_free_wc()is invoked with size=0 because of a typo, that triggers "kernel BUG atmm/vmalloc.c:124!".Signed-off-by Dmitry Osipenko <[email protected]>--- drivers/gpu/host1x/cdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel