Skip to contentSkip to conversation

mfd: intel-lpss: Program REMAP register in PIO mode

PATCH In review Andy Shevchenko 3 participants 7 messages Apr 24, 2018 – Jun 4, 2018

Subsystems (2)
Multifunction devices (MFD) Intel LPSS (Low Power SubSystem) drivers
lore
Share & tools
lore

Andy Shevchenko

author reviewer
#0 lore raw

PATCH 1/1 mfd: intel-lpss: Program REMAP register in PIO mode

According to documentation REMAP register has to be programmed in either DMA or PIO mode of the slice.

Move the DMA capability check below to let REMAP register be programmed in PIO mode.

Fixes 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
Cc Mika Westerberg <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/mfd/intel-lpss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mfd/intel-lpss.c +2 -2
index 9e545eb6e8b4..4bcf117a7ba8 100644
@@ -275,11 +275,11 @@ static void intel_lpss_init_dev(const struct intel_lpss *lpss)
 
 	intel_lpss_deassert_reset(lpss);
 
+	intel_lpss_set_remap_addr(lpss);
+
 	if (!intel_lpss_has_idma(lpss))
 		return;
 
-	intel_lpss_set_remap_addr(lpss);
-
 	/* Make sure that SPI multiblock DMA transfers are re-enabled */
 	if (lpss->type == LPSS_DEV_SPI)
 		writel(value, lpss->priv + LPSS_PRIV_SSP_REG);
Signature · 1 line
2.17.0
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Andy Shevchenko

According to documentation REMAP register has to be programmed in either DMA or PIO mode of the slice.

Move the DMA capability check below to let REMAP register be programmed in PIO mode.

Fixes 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
Cc Mika Westerberg <[email protected]>
Acked-by Mika Westerberg <[email protected]>
author reviewer
#2 lore raw
Quoted 8 lines · Mika Westerberg
Quoted 7 lines · Andy Shevchenko

According to documentation REMAP register has to be programmed in either DMA or PIO mode of the slice.

Move the DMA capability check below to let REMAP register be programmed
in PIO mode.

Quoted 5 lines
Quoted 3 lines
Fixes 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS

devices")
Cc: Mika Westerberg <[email protected]>

Acked-by Mika Westerberg <[email protected]>

Lee, can we have this applied in next rc cycle?

Signature · 2 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy
#3 lore raw
Quoted 9 lines · Andy Shevchenko
Quoted 8 lines · Mika Westerberg
Quoted 7 lines · Andy Shevchenko

According to documentation REMAP register has to be programmed in either DMA or PIO mode of the slice.

Move the DMA capability check below to let REMAP register be programmed
in PIO mode.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Fixes 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS

devices")
Cc: Mika Westerberg <[email protected]>

Acked-by Mika Westerberg <[email protected]>

Lee, can we have this applied in next rc cycle?

This has been broken since v4.3.

We'll roll it into v4.18 and tag it for -stable.

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#4 lore raw
In reply to Andy Shevchenko
Quoted 6 lines · Andy Shevchenko

According to documentation REMAP register has to be programmed in either DMA or PIO mode of the slice.

Move the DMA capability check below to let REMAP register be programmed in PIO mode.

Quoted 6 lines
Fixes 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
Cc Mika Westerberg <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/mfd/intel-lpss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied and tagged for -stable # 4.3+

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
author reviewer
#5 lore raw
Quoted 17 lines · Lee Jones
Quoted 7 lines · Andy Shevchenko

According to documentation REMAP register has to be programmed in either DMA or PIO mode of the slice.

Move the DMA capability check below to let REMAP register be programmed
in PIO mode.

Quoted 7 lines
Fixes 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS

devices")

Cc Mika Westerberg <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/mfd/intel-lpss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 1 line

Applied and tagged for -stable # 4.3+

Thanks!

Though can not see it in Linus' tree still.

Signature · 2 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy
#6 lore raw
Quoted 18 lines · Andy Shevchenko
Quoted 17 lines · Lee Jones
Quoted 14 lines · Andy Shevchenko

According to documentation REMAP register has to be programmed in either DMA or PIO mode of the slice.

Move the DMA capability check below to let REMAP register be programmed
in PIO mode.

Fixes 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS

devices")

Cc Mika Westerberg <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/mfd/intel-lpss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 5 lines
Quoted 1 line

Applied and tagged for -stable # 4.3+

Thanks!

Though can not see it in Linus' tree still.

Why would it be in Linus' tree?

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog