Skip to contentSkip to conversation

dma mapping fixes for 4.17-rc3

GIT PULL Christoph Hellwig 2 participants 4 messages Apr 25, 2018

lore
Share & tools
lore
#0 lore raw

The following changes since commit 6d08b06e67cd117f6992c46611dfb4ce267cd71e:

Linux 4.17-rc2 (2018-04-22 19:20:09 -0700)

are available in the Git repository at:

git://git.infradead.org/users/hch/dma-mapping.git tags/dma-mapping-4.17-3

for you to fetch changes up to 60695be2bb6b0623f8e53bd9949d582a83c6d44a:

dma-mapping: postpone cpu addr translation on mmap (2018-04-23 14:44:24 +0200)

----------------------------------------------------------------
A few small dma-mapping fixes for Linux 4.17-rc3:

- don't loop to try GFP_DMA allocations if ZONE_DMA is not actually enabled (regression in 4.16)
- don't try to do virt_to_page before we know we actuall have a valid page in dma_common_mmap
- a comment fixup related to the above fix

----------------------------------------------------------------
Jacopo Mondi (1):
dma-mapping: postpone cpu addr translation on mmap

Robin Murphy (1):
dma-coherent: clarify dma_mmap_from_dev_coherent documentation

Takashi Iwai (1):
dma-direct: don't retry allocation for no-op GFP_DMA

 drivers/base/dma-coherent.c | 5 +++--
 drivers/base/dma-mapping.c  | 6 ++----
 lib/dma-direct.c            | 3 ++-
 3 files changed, 7 insertions(+), 7 deletions(-)
#1 lore raw
Quoted 10 lines · Christoph Hellwig

The following changes since commit 6d08b06e67cd117f6992c46611dfb4ce267cd71e:

Linux 4.17-rc2 (2018-04-22 19:20:09 -0700)

are available in the Git repository at:

git://git.infradead.org/users/hch/dma-mapping.git tags/dma-mapping-4.17-3

for you to fetch changes up to 60695be2bb6b0623f8e53bd9949d582a83c6d44a:

Quoted 7 lines

dma-mapping: postpone cpu addr translation on mmap (2018-04-23 14:44:24 +0200)

----------------------------------------------------------------
A few small dma-mapping fixes for Linux 4.17-rc3:

- don't loop to try GFP_DMA allocations if ZONE_DMA is not actually enabled (regression in 4.16)

Shouldn't that test for dev->coherent_dma_mask < DMA_BIT_MASK(32) be more accurately <=?

#2 lore raw
Quoted 2 lines · David Rientjes

Shouldn't that test for dev->coherent_dma_mask < DMA_BIT_MASK(32) be more accurately <=?

No, it should really be <. The exactly 32-bit case is already covered with GFP_DMA32. Eventualy it should be < 24-bit with a separate GFP_DMA32 case for > 32-bit && < 64-bit. Takashi has been working on that, but it is 4.18 material.

#3 lore raw
Quoted 9 lines · Christoph Hellwig
Quoted 2 lines · David Rientjes

Shouldn't that test for dev->coherent_dma_mask < DMA_BIT_MASK(32) be more accurately <=?

No, it should really be <. The exactly 32-bit case is already covered with GFP_DMA32. Eventualy it should be < 24-bit with a separate GFP_DMA32 case for > 32-bit && < 64-bit. Takashi has been working on that, but it is 4.18 material.

Ack, thanks.