Skip to contentSkip to conversation

dt-bindings: staging: remove a couple of ADC bindings

PATCH In review Rob Herring 3 participants 5 messages Apr 26, 2018 – Apr 30, 2018

Subsystems (2)
Device tree bindings Arm/LPC32XX SoC support
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: staging: remove a couple of ADC bindings

Remove LPC32xx and SPEAr ADC bindings in staging. They have not been touched since 2012.

Cc Roland Stigge <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Viresh Kumar <[email protected]>
Signed-off-by Rob Herring <[email protected]>

---
Move these out of staging please or they are going to be removed.

 .../bindings/staging/iio/adc/lpc32xx-adc.txt       | 16 -------------
 .../bindings/staging/iio/adc/spear-adc.txt         | 26 ----------------------
 2 files changed, 42 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt
 delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt
Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt deleted +0 -16
deleted file mode 100644
index b3629d3a9adf..000000000000
@@ -1,16 +0,0 @@
-* NXP LPC32xx SoC ADC controller
-
-Required properties:
-- compatible: must be "nxp,lpc3220-adc"
-- reg: physical base address of the controller and length of memory mapped
-  region.
-- interrupts: The ADC interrupt
-
-Example:
-
-	adc@40048000 {
-		compatible = "nxp,lpc3220-adc";
-		reg = <0x40048000 0x1000>;
-		interrupt-parent = <&mic>;
-		interrupts = <39 0>;
-	};
Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt deleted +0 -26
deleted file mode 100644
index 02ea23a63f20..000000000000
@@ -1,26 +0,0 @@
-* ST SPEAr ADC device driver
-
-Required properties:
-- compatible: Should be "st,spear600-adc"
-- reg: Address and length of the register set for the device
-- interrupt-parent: Should be the phandle for the interrupt controller
-  that services interrupts for this device
-- interrupts: Should contain the ADC interrupt
-- sampling-frequency: Default sampling frequency
-
-Optional properties:
-- vref-external: External voltage reference in milli-volts. If omitted
-  the internal voltage reference will be used.
-- average-samples: Number of samples to generate an average value. If
-  omitted, single data conversion will be used.
-
-Examples:
-
-	adc: adc@d8200000 {
-		compatible = "st,spear600-adc";
-		reg = <0xd8200000 0x1000>;
-		interrupt-parent = <&vic1>;
-		interrupts = <6>;
-		sampling-frequency = <5000000>;
-		vref-external = <2500>;	/* 2.5V VRef */
-	};
Signature · 1 line
2.14.1
#1 lore raw

@Thomas: Do you guys use this ?

Quoted 73 lines · Rob Herring

Remove LPC32xx and SPEAr ADC bindings in staging. They have not been touched since 2012.

Cc Roland Stigge <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Viresh Kumar <[email protected]>
Signed-off-by Rob Herring <[email protected]>

---
Move these out of staging please or they are going to be removed.

 .../bindings/staging/iio/adc/lpc32xx-adc.txt       | 16 -------------
 .../bindings/staging/iio/adc/spear-adc.txt         | 26 ----------------------
 2 files changed, 42 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt
 delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt
Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt deleted +0 -16
deleted file mode 100644
index b3629d3a9adf..000000000000
@@ -1,16 +0,0 @@
-* NXP LPC32xx SoC ADC controller
-
-Required properties:
-- compatible: must be "nxp,lpc3220-adc"
-- reg: physical base address of the controller and length of memory mapped
-  region.
-- interrupts: The ADC interrupt
-
-Example:
-
-	adc@40048000 {
-		compatible = "nxp,lpc3220-adc";
-		reg = <0x40048000 0x1000>;
-		interrupt-parent = <&mic>;
-		interrupts = <39 0>;
-	};
Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt deleted +0 -26
deleted file mode 100644
index 02ea23a63f20..000000000000
@@ -1,26 +0,0 @@
-* ST SPEAr ADC device driver
-
-Required properties:
-- compatible: Should be "st,spear600-adc"
-- reg: Address and length of the register set for the device
-- interrupt-parent: Should be the phandle for the interrupt controller
-  that services interrupts for this device
-- interrupts: Should contain the ADC interrupt
-- sampling-frequency: Default sampling frequency
-
-Optional properties:
-- vref-external: External voltage reference in milli-volts. If omitted
-  the internal voltage reference will be used.
-- average-samples: Number of samples to generate an average value. If
-  omitted, single data conversion will be used.
-
-Examples:
-
-	adc: adc@d8200000 {
-		compatible = "st,spear600-adc";
-		reg = <0xd8200000 0x1000>;
-		interrupt-parent = <&vic1>;
-		interrupts = <6>;
-		sampling-frequency = <5000000>;
-		vref-external = <2500>;	/* 2.5V VRef */
-	};
Signature · 1 line
2.14.1
Signature · 1 line
viresh
#2 lore raw

Hello,

Quoted 17 lines · Viresh Kumar

@Thomas: Do you guys use this ?

Quoted 14 lines · Rob Herring

Remove LPC32xx and SPEAr ADC bindings in staging. They have not been touched since 2012.

Cc Roland Stigge <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Viresh Kumar <[email protected]>
Signed-off-by Rob Herring <[email protected]>

---
Move these out of staging please or they are going to be removed.

 .../bindings/staging/iio/adc/lpc32xx-adc.txt       | 16 -------------
 .../bindings/staging/iio/adc/spear-adc.txt         | 26 ----------------------
 2 files changed, 42 deletions(-)

We are using the spear-adc driver, which is out of staging in ./drivers/iio/adc/spear_adc.c. So rather than removing its DT binding entirely, it should be moved out of staging.

I'm not using the LPC32xx ADC, but the IIO driver is also out of staging, so for the same reason, it would be strange to remove the DT binding.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
author maintainer
#3 lore raw
Quoted 17 lines · Thomas Petazzoni

Hello,

Quoted 14 lines · Viresh Kumar

@Thomas: Do you guys use this ?

Quoted 11 lines · Rob Herring

Remove LPC32xx and SPEAr ADC bindings in staging. They have not been touched since 2012.

Cc Roland Stigge <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Viresh Kumar <[email protected]>
Signed-off-by Rob Herring <[email protected]>

---
Move these out of staging please or they are going to be removed.

Quoted 7 lines
Quoted 3 lines
Quoted 3 lines
 .../bindings/staging/iio/adc/lpc32xx-adc.txt       | 16 -------------
 .../bindings/staging/iio/adc/spear-adc.txt         | 26 ----------------------
 2 files changed, 42 deletions(-)

We are using the spear-adc driver, which is out of staging in ./drivers/iio/adc/spear_adc.c. So rather than removing its DT binding entirely, it should be moved out of staging.

Except I have comments on the spear binding and it's fair game to change it being in staging, right?

Rob

#4 lore raw

Hello,

Quoted 10 lines · Rob Herring
Quoted 7 lines
Quoted 3 lines
Quoted 3 lines
 .../bindings/staging/iio/adc/lpc32xx-adc.txt       | 16 -------------
 .../bindings/staging/iio/adc/spear-adc.txt         | 26 ----------------------
 2 files changed, 42 deletions(-)

We are using the spear-adc driver, which is out of staging in ./drivers/iio/adc/spear_adc.c. So rather than removing its DT binding entirely, it should be moved out of staging.

Except I have comments on the spear binding and it's fair game to change it being in staging, right?

Sure, I don't care about binding changes. We ship the DT together with the kernel on those SPEAr600 devices, so the DT backward compatibility is totally useless for us, which allows to freely change the bindings.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com