Skip to contentSkip to conversation

drm/i915/selftests: Potential uninitialized return in live_reset_whitelist()

PATCH In review Dan Carpenter 4 participants 4 messages Apr 27, 2018

Subsystems (3)
DRM drivers Intel i915 Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drm/i915/selftests: Potential uninitialized return in live_reset_whitelist()

Smatch complains that "err" could be uninitialized at the end. I don't know the code well but that seems like a reasonable warning.

Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/i915/selftests/intel_workarounds.c +1 -1
index 5455b2626627..17444a3abbb9 100644
@@ -239,7 +239,7 @@ static int live_reset_whitelist(void *arg)
 	struct intel_engine_cs *engine = i915->engine[RCS];
 	struct i915_gpu_error *error = &i915->gpu_error;
 	struct whitelist w;
-	int err;
+	int err = 0;
 
 	/* If we reset the gpu, we should not lose the RING_NONPRIV */
#1 lore raw
Quoted 10 lines · Dan Carpenter

Smatch complains that "err" could be uninitialized at the end. I don't know the code well but that seems like a reasonable warning.

Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/i915/selftests/intel_workarounds.c +0 -0
index 5455b2626627..17444a3abbb9 100644

drivers/gpu/drm/i915/selftests/intel_workarounds.c static int live_reset_whitelist(void *arg) · line 244

Quoted 7 lines
drivers/gpu/drm/i915/selftests/intel_workarounds.c +1 -1
@@ -239,7 +239,7 @@ static int live_reset_whitelist(void *arg)
 	struct intel_engine_cs *engine = i915->engine[RCS];
 	struct i915_gpu_error *error = &i915->gpu_error;
 	struct whitelist w;
-	int err;
+	int err = 0;
 
 	/* If we reset the gpu, we should not lose the RING_NONPRIV */

Looks like this is already fixed.

commit a3997159133d56e444f0c0f56ab1ae59863912a8

Author: Gustavo A. R. Silva <[email protected]>
Date:   Tue Apr 24 08:15:45 2018 -0500

drm/i915/selftests: Fix uninitialized variable

Signature · 6 lines
Ville Syrjälä
Intel
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
In reply to Dan Carpenter

Quoting Dan Carpenter (2018-04-27 15:06:16)

Quoted 4 lines

Smatch complains that "err" could be uninitialized at the end. I don't know the code well but that seems like a reasonable warning.

Signed-off-by Dan Carpenter <[email protected]>

Thanks for the report, Gustavo Silva already submitted the same fixup.

commit a3997159133d56e444f0c0f56ab1ae59863912a8

Author: Gustavo A. R. Silva <[email protected]>
Date:   Tue Apr 24 08:15:45 2018 -0500

drm/i915/selftests: Fix uninitialized variable

There is a potential execution path in which variable err is returned without being properly initialized previously.

Fix this by initializing variable err to 0.

Ta,
-Chris

CI
#3 lore raw

✗ Fi.CI.BAT: failure for drm/i915/selftests: Potential uninitialized return in live_reset_whitelist()

In reply to Dan Carpenter
== Series Details ==

== Series Details ==

Series: drm/i915/selftests: Potential uninitialized return in live_reset_whitelist()
URL : https://patchwork.freedesktop.org/series/42407/
State : failure

== Summary ==

Applying: drm/i915/selftests: Potential uninitialized return in live_reset_whitelist() Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/selftests/intel_workarounds.c
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx