Skip to contentSkip to conversation

dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

PATCH Applied Moritz Fischer 2 participants 2 messages Apr 28, 2018 – May 2, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

Request IRQ with IRQF_SHARED flag to enable setups with multiple instances of the core sharing a single IRQ line.
This works out since the IRQ handler already checks if there is an actual IRQ pending and returns IRQ_NONE otherwise.

---

Changes from v2:
- Reworded commit message

Changes from v1:
- Added Lars' Acked-by
- Dropped patch [1/2] and changed accordingly

---
 drivers/dma/dma-axi-dmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/dma-axi-dmac.c +1 -1
index 2419fe524daa..15b2453d2647 100644
@@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_unregister_device;
 
-	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
+	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, IRQF_SHARED,
 		dev_name(&pdev->dev), dmac);
 	if (ret)
 		goto err_unregister_of;
Applied
#1 lore raw
Quoted 4 lines · Moritz Fischer

Request IRQ with IRQF_SHARED flag to enable setups with multiple instances of the core sharing a single IRQ line.
This works out since the IRQ handler already checks if there is an actual IRQ pending and returns IRQ_NONE otherwise.

Applied, thanks

Signature · 1 line
~Vinod