typec: tcpm: Fix incorrect 'and' operator

PATCH In review Gustavo A. R. Silva 3 participants 3 messages Apr 30, 2018 – May 2, 2018

Subsystems (3)

USB Kernel janitors USB Type-C class

lore

Share & tools

lore

Gustavo A. R. Silva

author

2018-04-30 13:23 UTC #0 lore raw

PATCH 1/1 typec: tcpm: Fix incorrect 'and' operator

Currently, logical and is being used instead of *bitwise* and.

Fix this by using a proper bitwise and operator.

Addresses-Coverity-ID: 1468455 ("Logical vs. bitwise operator")

Fixes 64f7c494a3c0 ("typec: tcpm: Add support for sink PPS related

messages")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/usb/typec/tcpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/usb/typec/tcpm.c +1 -1

index 1ee259b..7ee417a 100644
@@ -1772,7 +1772,7 @@ static void tcpm_pd_ext_msg_request(struct tcpm_port *port,
 	enum pd_ext_msg_type type = pd_header_type_le(msg->header);
 	unsigned int data_size = pd_ext_header_data_size_le(msg->ext_msg.header);
 
-	if (!(msg->ext_msg.header && PD_EXT_HDR_CHUNKED)) {
+	if (!(msg->ext_msg.header & PD_EXT_HDR_CHUNKED)) {
 		tcpm_log(port, "Unchunked extended messages unsupported");
 		return;
 	}

Signature · 1 line

2.7.4

Adam Thomson

Acked-by on v1 1/1

2018-04-30 14:44 UTC #1 lore raw

Quoted 9 lines · Gustavo A. R. Silva

Currently, logical and is being used instead of *bitwise* and.
Fix this by using a proper bitwise and operator.
Addresses-Coverity-ID: 1468455 ("Logical vs. bitwise operator")
Fixes 64f7c494a3c0 ("typec: tcpm: Add support for sink PPS related
messages")
Signed-off-by Gustavo A. R. Silva <[email protected]>
---

Good spot. :(

Acked-by Adam Thomson <[email protected]>

Quoted 20 lines

 drivers/usb/typec/tcpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/usb/typec/tcpm.c +1 -1

index 1ee259b..7ee417a 100644
@@ -1772,7 +1772,7 @@ static void tcpm_pd_ext_msg_request(struct tcpm_port
 *port,
 	enum pd_ext_msg_type type = pd_header_type_le(msg->header);
 	unsigned int data_size = pd_ext_header_data_size_le(msg-
 >ext_msg.header);
 
-	if (!(msg->ext_msg.header && PD_EXT_HDR_CHUNKED)) {
+	if (!(msg->ext_msg.header & PD_EXT_HDR_CHUNKED)) {
 		tcpm_log(port, "Unchunked extended messages unsupported");

drivers/usb/typec/tcpm.c +0 -1

 		return;
 	}
--

2.7.4

Heikki Krogerus

maintainer Acked-by on v1 1/1

2018-05-02 14:07 UTC #2 lore raw

In reply to Gustavo A. R. Silva

Quoted 8 lines · Gustavo A. R. Silva

Currently, logical and is being used instead of *bitwise* and.
Fix this by using a proper bitwise and operator.
Addresses-Coverity-ID: 1468455 ("Logical vs. bitwise operator")
Fixes 64f7c494a3c0 ("typec: tcpm: Add support for sink PPS related
messages")
Signed-off-by Gustavo A. R. Silva <[email protected]>

Acked-by Heikki Krogerus <[email protected]>

Quoted 9 lines

---
 drivers/usb/typec/tcpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/usb/typec/tcpm.c +0 -0

index 1ee259b..7ee417a 100644

drivers/usb/typec/tcpm.c static void tcpm_pd_ext_msg_request(struct tcpm_port *port, · line 1778

Quoted 8 lines

drivers/usb/typec/tcpm.c +1 -1

@@ -1772,7 +1772,7 @@ static void tcpm_pd_ext_msg_request(struct tcpm_port *port,
 	enum pd_ext_msg_type type = pd_header_type_le(msg->header);
 	unsigned int data_size = pd_ext_header_data_size_le(msg->ext_msg.header);
 
-	if (!(msg->ext_msg.header && PD_EXT_HDR_CHUNKED)) {
+	if (!(msg->ext_msg.header & PD_EXT_HDR_CHUNKED)) {
 		tcpm_log(port, "Unchunked extended messages unsupported");
 		return;
 	}

Thanks,

Signature · 1 line

heikki