Skip to contentSkip to conversation

KVM: s390: generalize kvm_s390_get_tod_clock_ext()

PATCH David Hildenbrand 1 participant 1 message Apr 30, 2018 1 message not in the archive s390

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 29 lines · Collin Walling
Quoted 11 lines · David Hildenbrand

Move the Multiple-epoch facility handling into it and rename it to kvm_s390_get_tod_clock().

This leaves us with:
- kvm_s390_set_tod_clock()
- kvm_s390_get_tod_clock()
- kvm_s390_get_tod_clock_fast()

So all Multiple-epoch facility is hidden in these functions.

Aside from the one nit described below, looks good to me!

Quoted 12 lines
---
 arch/s390/kvm/kvm-s390.c | 22 +++++++++-------------
 1 file changed, 9 insertions(+), 13 deletions(-)
arch/s390/kvm/kvm-s390.c +0 -0
index b3eee3cc6e78..fb753b9439fa 100644
@@ -1033,8 +1033,8 @@ static int kvm_s390_set_tod(struct kvm *kvm, struct kvm_device_attr *attr)
 	return ret;
 }
 
Quoted 6 lines

arch/s390/kvm/kvm-s390.c static int kvm_s390_set_tod(struct kvm *kvm, struct kvm_device_attr *attr) · line 1037

Quoted 4 lines
arch/s390/kvm/kvm-s390.c +2 -2
-static void kvm_s390_get_tod_clock_ext(struct kvm *kvm,
-					struct kvm_s390_vm_tod_clock *gtod)
+static void kvm_s390_get_tod_clock(struct kvm *kvm,
+				   struct kvm_s390_vm_tod_clock *gtod)

Nit: add one more whitespace for the second line of parameters

It only looks like it's wrong in the patch file. The end result is correct.

Thanks!

Signature · 3 lines
Thanks,

David / dhildenb