Skip to contentSkip to conversation

perf session: Fix undeclared 'oe'

PATCH Superseded Murilo Opsfelder Araujo 1 participant 1 message Apr 30, 2018 1 message not in the archive Stable branch

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Murilo Opsfelder Araujo

author
#1 lore raw

PATCH v2 1/1 perf session: Fix undeclared 'oe'

In reply to a message not in the archive

Using linux-3.18.y branch, perf build fails with the following:

    $ make -s -j16 -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1 NO_LIBNUMA=1 NO_STRLCPY=1 NO_BIONIC=1 prefix=/usr DESTDIR=/tmp/builddir/build all
    [...]
    util/session.c: In function ‘__perf_session__process_pipe_events’:
    util/session.c:1093:36: error: ‘oe’ undeclared (first use in this function)
      ordered_events__set_copy_on_queue(oe, true);
                                        ^
    util/session.c:1093:36: note: each undeclared identifier is reported only once for each function it appears in

This patch fixes it for linux-3.18.y branch.

Fixes 95b33b99cdd6 ("perf inject: Copy events when reordering events in pipe mode")
Cc <[email protected]> # 3.18.x
Cc Alexander Shishkin <[email protected]>
Cc Andi Kleen <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc David Carrillo-Cisneros <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc He Kuang <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Masami Hiramatsu <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Paul Turner <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Sasha Levin <[email protected]>
Cc Simon Que <[email protected]>
Cc Stephane Eranian <[email protected]>
Cc Wang Nan <[email protected]>
Signed-off-by Murilo Opsfelder Araujo <[email protected]>
---
 tools/perf/util/session.c | 1 +
 1 file changed, 1 insertion(+)
tools/perf/util/session.c +1 -0
index dc3d3b1b813e..c2d4a7ec40df 100644
@@ -1073,6 +1073,7 @@ volatile int session_done;
 static int __perf_session__process_pipe_events(struct perf_session *session,
 					       struct perf_tool *tool)
 {
+	struct ordered_events *oe = &session->ordered_events;
 	int fd = perf_data_file__fd(session->file);
 	union perf_event *event;
 	uint32_t size, cur_size = 0;
Signature · 1 line
2.14.3