Skip to contentSkip to conversation

add common.h include to stdio_dev.h

PATCH New Peter Robinson 2 participants 3 messages May 2, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add common.h include to stdio_dev.h

stdio_dev.h references uchar which is defined in common.h and causes build failures on toolchains which have tightened build flags such as Fedora 28. This was causing build failures on devices such as Xilinx zynqmp targets which include stdio_dev.h via FPGA drivers.

---
 include/stdio_dev.h | 1 +
 1 file changed, 1 insertion(+)
include/stdio_dev.h +1 -0
index 3164fa2a55..eed4385100 100644
@@ -8,6 +8,7 @@
 #ifndef _STDIO_DEV_H_
 #define _STDIO_DEV_H_
 
+#include <common.h>
 #include <linux/list.h>
 
 /*
Signature · 1 line
2.17.0
#1 lore raw

PATCH 1/1 add common.h include to stdio_dev.h

Quoted 15 lines · Peter Robinson

stdio_dev.h references uchar which is defined in common.h and causes build failures on toolchains which have tightened build flags such as Fedora 28. This was causing build failures on devices such as Xilinx zynqmp targets which include stdio_dev.h via FPGA drivers.

---
 include/stdio_dev.h | 1 +
 1 file changed, 1 insertion(+)
include/stdio_dev.h +0 -0
index 3164fa2a55..eed4385100 100644

include/stdio_dev.h line 14

Quoted 7 lines
include/stdio_dev.h +1 -0
@@ -8,6 +8,7 @@
 #ifndef _STDIO_DEV_H_
 #define _STDIO_DEV_H_
 
+#include <common.h>
 #include <linux/list.h>
 
 /*

I have an alternative fix in progress here:
https://travis-ci.org/trini/u-boot/builds/373883559 as it looks like the section in question is just unused now.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180502/cec7026e/attachment.sig>
#2 lore raw

PATCH 1/1 add common.h include to stdio_dev.h

Quoted 20 lines · Tom Rini
Quoted 18 lines · Peter Robinson

stdio_dev.h references uchar which is defined in common.h and causes build failures on toolchains which have tightened build flags such as Fedora 28. This was causing build failures on devices such as Xilinx zynqmp targets which include stdio_dev.h via FPGA drivers.

---
 include/stdio_dev.h | 1 +
 1 file changed, 1 insertion(+)
include/stdio_dev.h +0 -0
index 3164fa2a55..eed4385100 100644
@@ -8,6 +8,7 @@
 #ifndef _STDIO_DEV_H_
 #define _STDIO_DEV_H_
 
Quoted 8 lines

include/stdio_dev.h line 14

Quoted 4 lines
include/stdio_dev.h +1 -0
+#include <common.h>
 #include <linux/list.h>
 
 /*

I have an alternative fix in progress here:
https://travis-ci.org/trini/u-boot/builds/373883559 as it looks like the section in question is just unused now.

Cool, works for me if it builds ;-)