lib/string_helpers: Add missed declaration of struct task_struct
PATCH 1/1 lib/string_helpers: Add missed declaration of struct task_struct
Starting from the commit 0d0443288f22 the new function has been introduced which takes struct task_struct as a parameter. Though, compiler doesn't know where to get information about it at this stage.
Add missed declaration of struct task_struct to satisfy compiler.
--- include/linux/string_helpers.h | 1 + 1 file changed, 1 insertion(+)
include/linux/string_helpers.h +1 -0
@@ -5,6 +5,7 @@#include <linux/types.h> struct file ; +struct task_struct ;/* Descriptions of the types of units to * print in */
Signature · 1 line
2.17.0
Quoted 10 lines · Andy Shevchenko
Starting from the commit
0d0443288f22the new function has been introduced which takes structtask_structas a parameter. Though, compiler doesn't know where to get information about it at this stage.Add missed declaration of struct
task_structto satisfy compiler.Fixes 0d0443288f22 ("string_helpers: add kstrdup_quotable_cmdline")Cc Kees Cook <[email protected]>Cc James Morris <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
I'm not sure who should carry this. You're welcome to put it in your tree?
-Kees
Quoted 19 lines
--- include/linux/string_helpers.h | 1 + 1 file changed, 1 insertion(+)include/linux/string_helpers.h +1
-1@@ -5,6 +5,7 @@#include <linux/types.h> struct file ; +struct task_struct ;/* Descriptions of the types of units to * print in */ --2.17.0
Signature · 2 lines
Kees Cook Pixel Security
Quoted 8 lines · Kees Cook
Quoted 6 lines · Andy Shevchenko
Starting from the commit
0d0443288f22the new function has been introduced which takes structtask_structas a parameter. Though, compiler doesn't know where to get information about it at this stage.Add missed declaration of struct
task_structto satisfy compiler.
Quoted 8 lines
Quoted 4 lines
Fixes 0d0443288f22 ("string_helpers: add kstrdup_quotable_cmdline")Cc Kees Cook <[email protected]>Cc James Morris <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>Acked-by Kees Cook <[email protected]>I'm not sure who should carry this. You're welcome to put it in your tree?
I haven't seen this show up in linux-next. Andy will you be taking it?
-Kees
Quoted 28 lines
-Kees
Quoted 17 lines
--- include/linux/string_helpers.h | 1 + 1 file changed, 1 insertion(+)include/linux/string_helpers.h +1
-1@@ -5,6 +5,7 @@#include <linux/types.h> struct file ; +struct task_struct ;/* Descriptions of the types of units to * print in */ --Quoted 2 lines
2.17.0
--
Kees Cook
Pixel Security
Signature · 2 lines
Kees Cook Pixel Security
Quoted 14 lines · Kees Cook
Quoted 13 lines · Kees Cook
Quoted 10 lines · Andy Shevchenko
Starting from the commit
0d0443288f22the new function has been introduced which takes structtask_structas a parameter. Though, compiler doesn't know where to get information about it at this stage.Add missed declaration of struct
task_structto satisfy compiler.Fixes 0d0443288f22 ("string_helpers: add kstrdup_quotable_cmdline")Cc Kees Cook <[email protected]>Cc James Morris <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
Quoted 5 lines
Quoted 3 lines
Acked-by Kees Cook <[email protected]>I'm not sure who should carry this. You're welcome to put it in your tree?
I haven't seen this show up in linux-next. Andy will you be taking it?
Will be in next next.
Signature · 2 lines
With Best Regards, Andy Shevchenko