Skip to contentSkip to conversation

mmc: tegra: remove redundant return statement

PATCH Applied Aapo Vienamo 4 participants 4 messages May 4, 2018 – May 8, 2018

Subsystems (3)
MMC, SD and SDIO Tegra architecture support Secure digital host controller interface (SDHCI) driver
lore
Share & tools
lore

Aapo Vienamo

author
#0 lore raw

PATCH 1/1 mmc: tegra: remove redundant return statement

A redundant return statement is removed from tegra_sdhci_set_uhs_signaling(). The function returns void and the return does not affect the control flow of the function.

Signed-off-by Aapo Vienamo <[email protected]>
---
 drivers/mmc/host/sdhci-tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-tegra.c +1 -1
index b877c13184c2..970d38f68939 100644
@@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host,
 	if (timing == MMC_TIMING_UHS_DDR50)
 		tegra_host->ddr_signaling = true;
 
-	return sdhci_set_uhs_signaling(host, timing);
+	sdhci_set_uhs_signaling(host, timing);
 }
 
 static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host)
Signature · 1 line
2.16.1
Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Aapo Vienamo

A redundant return statement is removed from tegra_sdhci_set_uhs_signaling(). The function returns void and the return does not affect the control flow of the function.

Signed-off-by Aapo Vienamo <[email protected]>
---
 drivers/mmc/host/sdhci-tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-tegra.c +0 -0
index b877c13184c2..970d38f68939 100644

drivers/mmc/host/sdhci-tegra.c static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host, · line 237

Quoted 8 lines
drivers/mmc/host/sdhci-tegra.c +1 -1
@@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host,
 	if (timing == MMC_TIMING_UHS_DDR50)
 		tegra_host->ddr_signaling = true;
 
-	return sdhci_set_uhs_signaling(host, timing);
+	sdhci_set_uhs_signaling(host, timing);
 }
 
 static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host)

Good catch!

Acked-by Thierry Reding <[email protected]>
maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Aapo Vienamo
Quoted 5 lines · Aapo Vienamo

A redundant return statement is removed from tegra_sdhci_set_uhs_signaling(). The function returns void and the return does not affect the control flow of the function.

Signed-off-by Aapo Vienamo <[email protected]>
Acked-by Adrian Hunter <[email protected]>
Quoted 18 lines
---
 drivers/mmc/host/sdhci-tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-tegra.c +1 -1
index b877c13184c2..970d38f68939 100644
@@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host,
 	if (timing == MMC_TIMING_UHS_DDR50)
 		tegra_host->ddr_signaling = true;
 
-	return sdhci_set_uhs_signaling(host, timing);
+	sdhci_set_uhs_signaling(host, timing);
 }
 
 static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host)
Applied
#3 lore raw
In reply to Aapo Vienamo
Quoted 5 lines · Aapo Vienamo

A redundant return statement is removed from tegra_sdhci_set_uhs_signaling(). The function returns void and the return does not affect the control flow of the function.

Signed-off-by Aapo Vienamo <[email protected]>

Thanks, applied for next!

Kind regards
Uffe

Quoted 20 lines
---
 drivers/mmc/host/sdhci-tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-tegra.c +1 -2
index b877c13184c2..970d38f68939 100644
@@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host,
        if (timing == MMC_TIMING_UHS_DDR50)
                tegra_host->ddr_signaling = true;
 
-       return sdhci_set_uhs_signaling(host, timing);
+       sdhci_set_uhs_signaling(host, timing);
 }
 
 static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host)
--

2.16.1