Skip to contentSkip to conversation

spi: kirkwood: Full dm conversion

PATCH New Jagan Teki 2 participants 4 messages May 7, 2018 – Nov 20, 2018 SPI

lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH v3 6/6 spi: kirkwood: Full dm conversion

kirkwood now support dt along with platform data, respective boards need to switch into dm for the same.

---
Changes for v3:
- rebased master
- Move kconfig option if DM_SPI

 drivers/spi/Kconfig                     |  12 +-
 drivers/spi/kirkwood_spi.c              | 240 ++++++--------------------------
 include/dm/platform_data/spi_kirkwood.h |  15 ++
 3 files changed, 62 insertions(+), 205 deletions(-)
 create mode 100644 include/dm/platform_data/spi_kirkwood.h
drivers/spi/Kconfig +6 -6
index 73dd33f716..64567cf6e9 100644
@@ -105,6 +105,12 @@ config ICH_SPI
 	  access the SPI NOR flash on platforms embedding this Intel
 	  ICH IP core.
 
+config KIRKWOOD_SPI
+	bool "Marvell Kirkwood SPI Driver"
+	help
+	  Enable support for SPI on various Marvell SoCs, such as
+	  Kirkwood and Armada 375.
+
 config MPC8XXX_SPI
 	bool "MPC8XXX SPI Driver"
 	help
@@ -283,12 +289,6 @@ config SH_QSPI
 	  Enable the Renesas Quad SPI controller driver. This driver can be
 	  used on Renesas SoCs.
 
-config KIRKWOOD_SPI
-	bool "Marvell Kirkwood SPI Driver"
-	help
-	  Enable support for SPI on various Marvell SoCs, such as
-	  Kirkwood and Armada 375.
-
 config LPC32XX_SSP
 	bool "LPC32XX SPI Driver"
 	help
drivers/spi/kirkwood_spi.c +41 -199

326 lines not on this page · raw message

include/dm/platform_data/spi_kirkwood.h new file +15 -0
new file mode 100644
index 0000000000..ae9b2783a9
@@ -0,0 +1,15 @@
+/*
+ * Copyright (C) 2018 Jagan Teki <[email protected]>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef __spi_kirkwood_h
+#define __spi_kirkwood_h
+
+struct mvebu_spi_platdata {
+	struct kwspi_registers *spireg;
+	bool is_errata_50mhz_ac;
+};
+
+#endif /* __spi_kirkwood_h */
Signature · 1 line
2.14.3
author
#1 lore raw

PATCH v3 6/6 spi: kirkwood: Full dm conversion

Quoted 10 lines · Jagan Teki

kirkwood now support dt along with platform data, respective boards need to switch into dm for the same.

---
Changes for v3:
- rebased master
- Move kconfig option if DM_SPI

Quoted 5 lines
 drivers/spi/Kconfig                     |  12 +-
 drivers/spi/kirkwood_spi.c              | 240 ++++++--------------------------
 include/dm/platform_data/spi_kirkwood.h |  15 ++
 3 files changed, 62 insertions(+), 205 deletions(-)
 create mode 100644 include/dm/platform_data/spi_kirkwood.h

Any update from the board maintainers about this changes, I would like to push this sooner as possible.

#2 lore raw

PATCH v3 6/6 spi: kirkwood: Full dm conversion

Am 2018-11-05 10:58, schrieb Jagan Teki:

Quoted 19 lines
Quoted 10 lines · Jagan Teki

kirkwood now support dt along with platform data, respective boards need to switch into dm for the same.

---
Changes for v3:
- rebased master
- Move kconfig option if DM_SPI

Quoted 6 lines
 drivers/spi/Kconfig                     |  12 +-
 drivers/spi/kirkwood_spi.c              | 240 
++++++--------------------------
 include/dm/platform_data/spi_kirkwood.h |  15 ++
 3 files changed, 62 insertions(+), 205 deletions(-)
 create mode 100644 include/dm/platform_data/spi_kirkwood.h
Quoted 2 lines

Any update from the board maintainers about this changes, I would like to push this sooner as possible.

Hi,

oh isn't this merged yet? Because my change [1] which depends on that made it already into the main tree [2].

[1]
http://git.denx.de/?p=u-boot.git;a=commit;h=134a6b6884c1faa893256ac5b02a301d0be863c8
[2] https://patchwork.ozlabs.org/patch/922392/

-michael

author
#3 lore raw

PATCH v3 6/6 spi: kirkwood: Full dm conversion

Quoted 21 lines · Michael Walle

Am 2018-11-05 10:58, schrieb Jagan Teki:

Quoted 19 lines
Quoted 16 lines · Jagan Teki

kirkwood now support dt along with platform data, respective boards need to switch into dm for the same.

---
Changes for v3:
- rebased master
- Move kconfig option if DM_SPI

 drivers/spi/Kconfig                     |  12 +-
 drivers/spi/kirkwood_spi.c              | 240
++++++--------------------------
 include/dm/platform_data/spi_kirkwood.h |  15 ++
 3 files changed, 62 insertions(+), 205 deletions(-)
 create mode 100644 include/dm/platform_data/spi_kirkwood.h
Quoted 8 lines
Quoted 2 lines

Any update from the board maintainers about this changes, I would like to push this sooner as possible.

Hi,

oh isn't this merged yet? Because my change [1] which depends on that made it already into the main tree [2].

There are many boards need to move DM_SPI [3], anyway I'm going to remove this driver.

[3] https://travis-ci.org/openedev/u-boot-amarula/builds/457097203