Skip to contentSkip to conversation

drm/xen-front: checking for NULL instead of IS_ERR

PATCH Applied Dan Carpenter 2 participants 5 messages May 8, 2018

Subsystems (4)
DRM drivers DRM misc Kernel janitors DRM drivers for Xen
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/3 drm/xen-front: checking for NULL instead of IS_ERR

drm_dev_alloc() returns error pointers, it never returns NULL.

Fixes c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/xen/xen_drm_front.c +2 -2
index 1b0ea9ac330e..8615e8522c7a 100644
@@ -543,8 +543,8 @@ static int xen_drm_drv_init(struct xen_drm_front_info *front_info)
 	front_info->drm_info = drm_info;
 
 	drm_dev = drm_dev_alloc(&xen_drm_driver, dev);
-	if (!drm_dev) {
-		ret = -ENOMEM;
+	if (IS_ERR(drm_dev)) {
+		ret = PTR_ERR(drm_dev);
 		goto fail;
 	}
Reviewed-by on v1 1/3
#1 lore raw
Quoted 4 lines · Dan Carpenter

drm_dev_alloc() returns error pointers, it never returns NULL.

Fixes c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")
Signed-off-by Dan Carpenter <[email protected]>

Thank you,

Reviewed-by Oleksandr Andrushchenko <[email protected]>
Quoted 20 lines
drivers/gpu/drm/xen/xen_drm_front.c +2 -2
index 1b0ea9ac330e..8615e8522c7a 100644
@@ -543,8 +543,8 @@ static int xen_drm_drv_init(struct xen_drm_front_info *front_info)
  	front_info->drm_info = drm_info;
 
  	drm_dev = drm_dev_alloc(&xen_drm_driver, dev);
-	if (!drm_dev) {
-		ret = -ENOMEM;
+	if (IS_ERR(drm_dev)) {
+		ret = PTR_ERR(drm_dev);
  		goto fail;
  	}

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reviewed-by on v1 1/3
#4 lore raw
In reply to Dan Carpenter
Quoted 4 lines · Dan Carpenter

drm_dev_alloc() returns error pointers, it never returns NULL.

Fixes c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")
Signed-off-by Dan Carpenter <[email protected]>

Thank you,

Reviewed-by Oleksandr Andrushchenko <[email protected]>
Quoted 16 lines
drivers/gpu/drm/xen/xen_drm_front.c +2 -2
index 1b0ea9ac330e..8615e8522c7a 100644
@@ -543,8 +543,8 @@ static int xen_drm_drv_init(struct xen_drm_front_info *front_info)
  	front_info->drm_info = drm_info;
 
  	drm_dev = drm_dev_alloc(&xen_drm_driver, dev);
-	if (!drm_dev) {
-		ret = -ENOMEM;
+	if (IS_ERR(drm_dev)) {
+		ret = PTR_ERR(drm_dev);
  		goto fail;
  	}
Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

Applied
#2 lore raw
In reply to Oleksandr Andrushchenko
Quoted 8 lines · Oleksandr Andrushchenko
Quoted 5 lines · Dan Carpenter

drm_dev_alloc() returns error pointers, it never returns NULL.

Fixes c575b7eeb89f ("drm/xen-front: Add support for Xen PV display

frontend")

Signed-off-by Dan Carpenter <[email protected]>

Thank you,

Reviewed-by Oleksandr Andrushchenko <[email protected]>

Applied to drm-misc-next,
Thank you

Quoted 21 lines
Quoted 20 lines
drivers/gpu/drm/xen/xen_drm_front.c +2 -2
index 1b0ea9ac330e..8615e8522c7a 100644
@@ -543,8 +543,8 @@ static int xen_drm_drv_init(struct 
 xen_drm_front_info *front_info)
       front_info->drm_info = drm_info;
         drm_dev = drm_dev_alloc(&xen_drm_driver, dev);
-    if (!drm_dev) {
-        ret = -ENOMEM;
+    if (IS_ERR(drm_dev)) {
+        ret = PTR_ERR(drm_dev);
           goto fail;
       }

  _______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Applied
#3 lore raw
In reply to Oleksandr Andrushchenko
Quoted 7 lines · Oleksandr Andrushchenko
Quoted 4 lines · Dan Carpenter

drm_dev_alloc() returns error pointers, it never returns NULL.

Fixes c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")
Signed-off-by Dan Carpenter <[email protected]>

Thank you,

Reviewed-by Oleksandr Andrushchenko <[email protected]>

Applied to drm-misc-next,
Thank you

Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/xen/xen_drm_front.c +0 -2
index 1b0ea9ac330e..8615e8522c7a 100644
@@ -543,8 +543,8 @@ static int xen_drm_drv_init(struct 
 xen_drm_front_info *front_info)
       front_info->drm_info = drm_info;
         drm_dev = drm_dev_alloc(&xen_drm_driver, dev);
-    if (!drm_dev) {
-        ret = -ENOMEM;
Quoted 9 lines
Quoted 8 lines
drivers/gpu/drm/xen/xen_drm_front.c +2 -0
+    if (IS_ERR(drm_dev)) {
+        ret = PTR_ERR(drm_dev);
           goto fail;
       }

  _______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel