openh264: switch away from github archive
PATCH 1/1 openh264: switch away from github archive
Since we know that github archives which are automatically generated have a tendency to change their checksums[1], switch to using a git clone.
[1] http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html
--- .../recipes-multimedia/openh264/openh264_1.7.0.bb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb +4 -3
@@ -11,9 +11,10 @@ LICENSE = "BSD-2-Clause" LICENSE_FLAGS = "commercial" LIC_FILES_CHKSUM = "file://LICENSE;md5=bb6d3771da6a07d33fd50d4d9aa73bcf" -SRC_URI = "https://github.com/cisco/openh264/archive/v${PV}.tar.gz" -SRC_URI[md5sum] = "93da4e76cfda7ede8fd2df51b0021efd" -SRC_URI[sha256sum] = "9c07c38d7de00046c9c52b12c76a2af7648b70d05bd5460c8b67f6895738653f" +S = "${WORKDIR}/git" +SRCREV = "a180c9d4d6f1a4830ca9eed9d159d54996bd63cb" +OPENHBRANCH = "openh264v1.7" +SRC_URI = "git://github.com/cisco/openh264.git;protocol=https;branch=${OPENHBRANCH};" COMPATIBLE_MACHINE_armv7a = "(.*)" COMPATIBLE_MACHINE_aarch64 = "(.*)"
Signature · 1 line
2.17.0.rc2.3.gc2a499e6c
Quoted 15 lines · Trevor Woerner
Since we know that github archives which are automatically generated have a tendency to change their checksums[1], switch to using a git clone.
[1] http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html
Signed-off-by Trevor Woerner <[email protected]>--- .../recipes-multimedia/openh264/openh264_1.7.0.bb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb +0
-0
meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb LICENSE = "BSD-2-Clause" · line 16
Quoted 9 lines
meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb +3
-3@@ -11,9 +11,10 @@ LICENSE = "BSD-2-Clause" LICENSE_FLAGS = "commercial" LIC_FILES_CHKSUM = "file://LICENSE;md5=bb6d3771da6a07d33fd50d4d9aa73bcf" -SRC_URI = "https://github.com/cisco/openh264/archive/v${PV}.tar.gz" -SRC_URI[md5sum] = "93da4e76cfda7ede8fd2df51b0021efd" -SRC_URI[sha256sum] = "9c07c38d7de00046c9c52b12c76a2af7648b70d05bd5460c8b67f6895738653f" +S = "${WORKDIR}/git" +SRCREV = "a180c9d4d6f1a4830ca9eed9d159d54996bd63cb" +OPENHBRANCH = "openh264v1.7"
"openh264" is a combination of "open" and "h264", so using "openh" in this variable name looks a little odd?
Since the variable is local to the recipe, maybe just "BRANCH" would be OK?
Quoted 12 lines
meta-multimedia/recipes-multimedia/openh264/openh264_1.7.0.bb +1
-1+SRC_URI = "git://github.com/cisco/openh264.git;protocol=https;branch=${OPENHBRANCH};" COMPATIBLE_MACHINE_armv7a = "(.*)" COMPATIBLE_MACHINE_aarch64 = "(.*)" --2.17.0.rc2.3.gc2a499e6c
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 8 lines · Andre McCurdy
Quoted 1 line · Trevor Woerner
+OPENHBRANCH = "openh264v1.7"
"openh264" is a combination of "open" and "h264", so using "openh" in this variable name looks a little odd?
Since the variable is local to the recipe, maybe just "BRANCH" would be OK?
I assumed (but didn't test or check) that something as plain as BRANCH would conflict with any number of dozens of established internal variables :-) So I figured I'd scope it.
I'll try BRANCH and send a v2.