Skip to contentSkip to conversation

Revert "gcc: Remove patch causing ICE on x86_64 valgrind compile"

PATCH Superseded André Draszik 3 participants 5 messages May 11, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 Revert "gcc: Remove patch causing ICE on x86_64 valgrind compile"

From: André Draszik <[email protected]>

This reverts commit f76ee525a75dd6e443743bf723ad4511707c7f49.

With the patch removed we otherwise get QEMU (mipsel) segfaults:
--- SIGSEGV {si_signo=SIGSEGV, si_code=1, si_addr = 0x000d4e40} ---
qemu: uncaught target signal 11 (Segmentation fault) - core dumped Segmentation fault

---
 meta/recipes-devtools/gcc/gcc-6.4.inc              |  1 +
 ...-relax-the-restriction-on-subreg-reload-f.patch | 51 ++++++++++++++++++++++
 2 files changed, 52 insertions(+)
 create mode 100644 meta/recipes-devtools/gcc/gcc-6.4/0056-LRA-PR70904-relax-the-restriction-on-subreg-reload-f.patch
meta/recipes-devtools/gcc/gcc-6.4.inc +1 -0
index daa9e42af8..1803917f01 100644
@@ -81,6 +81,7 @@ SRC_URI = "\
            file://0048-sync-gcc-stddef.h-with-musl.patch \
            file://0054_all_nopie-all-flags.patch \
            file://0055-unwind_h-glibc26.patch \
+           file://0056-LRA-PR70904-relax-the-restriction-on-subreg-reload-f.patch \
            ${BACKPORTS} \
 "
 BACKPORTS = "\
meta/recipes-devtools/gcc/gcc-6.4/0056-LRA-PR70904-relax-the-restriction-on-subreg-reload-f.patch new file +51 -0

51 lines not on this page · raw message

Signature · 1 line
2.16.2
#1 lore raw

PATCH 2/2 gcc: Remove patch causing ICE on x86_64 valgrind compile (on x86-64 only)

From: André Draszik <[email protected]>

This is similar to commit f76ee525a75d, but instead of disabling the patch on all builds, we only remove it for x86-64 builds, as the original change's commit message mentined issues with this patch applied on that architecture only.

---
 meta/recipes-devtools/gcc/gcc-6.4.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-devtools/gcc/gcc-6.4.inc +3 -1
index 1803917f01..9a23863022 100644
@@ -81,9 +81,11 @@ SRC_URI = "\
            file://0048-sync-gcc-stddef.h-with-musl.patch \
            file://0054_all_nopie-all-flags.patch \
            file://0055-unwind_h-glibc26.patch \
-           file://0056-LRA-PR70904-relax-the-restriction-on-subreg-reload-f.patch \
+           ${LRA_PR70904_PATCH} \
            ${BACKPORTS} \
 "
+LRA_PR70904_PATCH = "file://0056-LRA-PR70904-relax-the-restriction-on-subreg-reload-f.patch"
+LRA_PR70904_PATCH_x86-64 = ""
 BACKPORTS = "\
            file://CVE-2016-6131.patch \
            file://0057-ARM-PR-82445-suppress-32-bit-aligned-ldrd-strd-peeph.patch \
Signature · 1 line
2.16.2
#2 lore raw

Re: [pyro][PATCH 2/2] gcc: Remove patch causing ICE on x86_64 valgrind compile (on x86-64 only)

Quoted 9 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of André Draszik
Sent: den 11 maj 2018 10:10
To: [email protected]
Subject: [OE-core] [pyro][PATCH 2/2] gcc: Remove patch causing ICE on x86_64 valgrind compile (on x86-64 only)

Quoted 5 lines

From: André Draszik <[email protected]>

This is similar to commit f76ee525a75d, but instead of disabling the patch on all builds, we only remove it for x86-64 builds, as the original change's commit message mentined issues with this

Change "mentined" to "mentioned".

Quoted 3 lines

patch applied on that architecture only.

//Peter

#3 lore raw

PATCH v2 2/2 gcc: Remove patch causing ICE on x86_64 valgrind compile (on x86-64 only)

In reply to André Draszik

From: André Draszik <[email protected]>

This is similar to commit f76ee525a75d, but instead of disabling the patch on all builds, we only remove it for x86-64 builds, as the original change's commit message mentioned issues with this patch applied on that architecture only.

---
 meta/recipes-devtools/gcc/gcc-6.4.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-devtools/gcc/gcc-6.4.inc +3 -1
index 1803917f01..9a23863022 100644
@@ -81,9 +81,11 @@ SRC_URI = "\
            file://0048-sync-gcc-stddef.h-with-musl.patch \
            file://0054_all_nopie-all-flags.patch \
            file://0055-unwind_h-glibc26.patch \
-           file://0056-LRA-PR70904-relax-the-restriction-on-subreg-reload-f.patch \
+           ${LRA_PR70904_PATCH} \
            ${BACKPORTS} \
 "
+LRA_PR70904_PATCH = "file://0056-LRA-PR70904-relax-the-restriction-on-subreg-reload-f.patch"
+LRA_PR70904_PATCH_x86-64 = ""
 BACKPORTS = "\
            file://CVE-2016-6131.patch \
            file://0057-ARM-PR-82445-suppress-32-bit-aligned-ldrd-strd-peeph.patch \
Signature · 1 line
2.16.2
#4 lore raw

Re: [pyro][PATCH 2/2] gcc: Remove patch causing ICE on x86_64 valgrind compile (on x86-64 only)

In reply to André Draszik
Quoted 7 lines · André Draszik

From: André Draszik <[email protected]>

This is similar to commit f76ee525a75d, but instead of disabling the patch on all builds, we only remove it for x86-64 builds, as the original change's commit message mentined issues with this patch applied on that architecture only.

this is better thanks

Quoted 30 lines
---
 meta/recipes-devtools/gcc/gcc-6.4.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-devtools/gcc/gcc-6.4.inc +3 -2
index 1803917f01..9a23863022 100644
@@ -81,9 +81,11 @@ SRC_URI = "\
            file://0048-sync-gcc-stddef.h-with-musl.patch \
            file://0054_all_nopie-all-flags.patch \
            file://0055-unwind_h-glibc26.patch \
-           file://0056-LRA-PR70904-relax-the-restriction-on-subreg-reload-f.patch \
+           ${LRA_PR70904_PATCH} \
            ${BACKPORTS} \
 "
+LRA_PR70904_PATCH = "file://0056-LRA-PR70904-relax-the-restriction-on-subreg-reload-f.patch"
+LRA_PR70904_PATCH_x86-64 = ""
 BACKPORTS = "\
            file://CVE-2016-6131.patch \
            file://0057-ARM-PR-82445-suppress-32-bit-aligned-ldrd-strd-peeph.patch \
--

2.16.2

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core