Skip to contentSkip to conversation

proc: Add a way to make network proc files writable

PATCH Alexey Dobriyan 1 participant 1 message May 15, 2018 VFS

lore
Share & tools
lore
#0 lore raw
Quoted 5 lines · Christoph Hellwig
Quoted 4 lines · David Howells

Provide two extra functions, proc_create_net_data_write() and proc_create_net_single_write() that act like their non-write versions but also set a write method in the proc_dir_entry struct.

Quoted 8 lines
Quoted 3 lines

An internal simple write function is provided that will copy its buffer and hand it to the pde->write() method if available (or give an error if not). The buffer may be modified by the write method.

I thought of doing something like this, aѕ it would remove tons of boilerplat code from a lot of procfs instances. But I'd also like to hear what Al and Alexey think of it. We also should offer this for non-net proc users as well.

For the record I hate both series. This is kmalloc disease with its dozens of signatures to do the same thing slightly differently. It is just runtime .text reduction is hard to argue against.

Function names become longer and signatures themselves become longer and now you're arguing about indentation and character limit.

I remember reading about abusing C99 intializers to emulate optional parameters somewhere. If it can be used (with bloat-o-meter in mind) it will be very much appreciated.

Currently there are

	->proc_fops
	simple seq_file
	custom seq_file with start and stop
	optional write hook
	->data pointer

which is already way too much.