Skip to contentSkip to conversation

ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list

PATCH Andy Shevchenko 1 participant 1 message Nov 13, 2018 4 messages not in the archive x86 platform drivers

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): CAHp75VfY3nYgoUD3kjkZrMHzg2MZVNhgWiXJtxZAfpx_3ZGELQ@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAJxRB+DUzxf2dAwBSPP2FTLkwXHGM22WvUM0yrLGB4inPE3O5A@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAJxRB+C3xzL_m755ifoVzPugCg=bCbb-_mMOvkoH7iUvs3MV8w@mail.gmail.com

#4 lore raw

+Cc: mailing lists

Quoted 2 lines · Loic Wei-Yu-Neng

Here you go,
I attached my patch.

Thanks, though in a kernel we have not using attachments. Moreover, since you forgot to include mailing lists the patchwork doesn't catch this either.

Can you send it in a regular way, i.e. using git format-patch ... && git send-email ... ?

Quoted 77 lines

I rebased it on top of today's latest:
* 7946462d31a0 (HEAD -> test) ideapad-laptop: Add Lenovo Yoga 2 13 to the no_hw_rfkill DMI list
* ccda4af0f4b9 (tag: v4.20-rc2, origin/master, origin/HEAD) Linux 4.20-rc2
* 7a3765ed66d1 Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

|\
| * 7236ead1b149 act_mirred: clear skb->tstamp on redirect
| * a9049ff9214d net: dsa: mv88e6xxx: Fix clearing of stats counters
| * 7ab412d33b4c tipc: fix link re-establish failure
| * 63c82997f5c0 net: sched: cls_flower: validate nested enc_opts_policy to avoid warning
| * fbd1d5245372 net: mvneta: correct typo
| * 62230715fd24 flow_dissector: do not dissect l4 ports for fragments
| * d02854dc1999 net: qualcomm: rmnet: Fix incorrect assignment of real_dev

Loic

Quoted 53 lines · Loic Wei-Yu-Neng

Hello Andy,
Sure let me do that.
Loic

Quoted 47 lines · On Fri, Oct 19, 2018, 4:29 AM Andy Shevchenko <[email protected] wrote:
Quoted 7 lines · Loic WEI YU NENG

Some Lenovo ideapad models lack a physical rfkill switch.
On Lenovo models Yoga 2 13, ideapad-laptop would wrongly report all radios as blocked by hardware which caused wireless network connections to fail.
Add these models without an rfkill switch to the no_hw_rfkill list.

I'm very sorry, but by some unclear reason this patch is missed in the tree and in our patchwork.
Does it still actual?

May you resend it rebased on top of our for-next branch?

Quoted 24 lines
---
 drivers/platform/x86/ideapad-laptop.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/platform/x86/ideapad-laptop.c +7 -1
index 535199c9e6bc..0a843c4ca4fc 100644
@@ -1114,6 +1114,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
                        DMI_MATCH(DMI_BOARD_NAME, "Yoga2"),
                },
        },
+       {
+               .ident = "Lenovo Yoga 2 13",
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"),
+               },
+       },
        {
                .ident = "Lenovo Yoga 3 1170 / 1470",
                .matches = {
--
Quoted 2 lines

2.17.0

--
With Best Regards,
Andy Shevchenko

--
Loic WEI YU NENG
US phone: +1 408 218 2826
FR phone: +33 674201069
email: [email protected]

Signature · 2 lines
With Best Regards,
Andy Shevchenko