Skip to contentSkip to conversation

PATCH v2] PM / OPP: silence an uninitialized variable warning

PATCH Dan Carpenter 2 participants 2 messages May 16, 2018

Subsystems (2)
Kernel janitors Operating performance points (OPP)
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

Smatch complains that it's possible we print "rate" in the debug output when it hasn't been initialized. It should be zero on that path.

Signed-off-by Dan Carpenter <[email protected]>

---
v2: fix it a different way

drivers/opp/of.c +1 -1
index 7026e9f484ea..6d15f05bfc28 100644
@@ -287,7 +287,7 @@ static int _opp_add_static_v2(struct opp_table *opp_table, struct device *dev,
 			      struct device_node *np)
 {
 	struct dev_pm_opp *new_opp;
-	u64 rate;
+	u64 rate = 0;
 	u32 val;
 	int ret;
 	bool rate_not_available = false;
#1 lore raw
Quoted 12 lines · Dan Carpenter

Smatch complains that it's possible we print "rate" in the debug output when it hasn't been initialized. It should be zero on that path.

Signed-off-by Dan Carpenter <[email protected]>

---
v2: fix it a different way

drivers/opp/of.c +0 -0
index 7026e9f484ea..6d15f05bfc28 100644

drivers/opp/of.c static int _opp_add_static_v2(struct opp_table *opp_table, struct device *dev, · line 293

Quoted 8 lines
drivers/opp/of.c +1 -1
@@ -287,7 +287,7 @@ static int _opp_add_static_v2(struct opp_table *opp_table, struct device *dev,
 			      struct device_node *np)
 {
 	struct dev_pm_opp *new_opp;
-	u64 rate;
+	u64 rate = 0;
 	u32 val;
 	int ret;
 	bool rate_not_available = false;

Applied and added the Fixes tag as well.

Signature · 1 line
viresh