KVM: PPC: Book3S HV: radix clear pte when unmapping

PATCH New Nicholas Piggin 1 participant 1 message May 17, 2018

Subsystems (2)

PowerPC KVM PowerPC

lore

Share & tools

lore

Nicholas Piggin

author reviewer

2018-05-17 07:06 UTC #0 lore raw

PATCH v3 2/8 KVM: PPC: Book3S HV: radix clear pte when unmapping

The current partition table unmap code clears the _PAGE_PRESENT bit out of the pte, which leaves pud_huge/pmd_huge true and does not clear pud_present/pmd_present. This can confuse subsequent page faults.

Signed-off-by Nicholas Piggin <[email protected]>

---
 arch/powerpc/kvm/book3s_64_mmu_radix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/powerpc/kvm/book3s_64_mmu_radix.c +1 -1

index b8ee740b317c..481da8f93fa4 100644
@@ -595,7 +595,7 @@ int kvm_unmap_radix(struct kvm *kvm, struct kvm_memory_slot *memslot,
 
 	ptep = __find_linux_pte(kvm->arch.pgtable, gpa, NULL, &shift);
 	if (ptep && pte_present(*ptep)) {
-		old = kvmppc_radix_update_pte(kvm, ptep, _PAGE_PRESENT, 0,
+		old = kvmppc_radix_update_pte(kvm, ptep, ~0UL, 0,
 					      gpa, shift);
 		kvmppc_radix_tlbie_page(kvm, gpa, shift);
 		if ((old & _PAGE_DIRTY) && memslot->dirty_bitmap) {

Signature · 1 line

2.17.0