Skip to contentSkip to conversation

net: MVGBE don't automatically select PHYLIB

PATCH New Chris Packham 4 participants 4 messages May 17, 2018 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: MVGBE don't automatically select PHYLIB

When Kconfig support was added for MVGBE it included automatically selected PHYLIB support. But MVGBE does not need PHYLIB it will build fine without it. Commit ed52ea507f12 ("net: add Kconfig for MVGBE") should have been a no-op in terms of build size but because of the selecting PHYLIB the openrd configs increased in size.

Remove the automatic selection of PHYLIB, boards that need it will have already enabled it in their config header file.

Fixes commit ed52ea507f12 ("net: add Kconfig for MVGBE")

---

Changes in v2:
- reword commit message to make the intent a bit clearer

 drivers/net/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/net/Kconfig +0 -1
index c962d7a72c0c..f2cc75f494e8 100644
@@ -181,7 +181,6 @@ config FTMAC100
 config MVGBE
 	bool "Marvell Orion5x/Kirkwood network interface support"
 	depends on KIRKWOOD || ORION5X
-	select PHYLIB
 	help
 	  This driver supports the network interface units in the
 	  Marvell Orion5x and Kirkwood SoCs
Signature · 1 line
2.17.0
#1 lore raw

PATCH v2 1/1 net: MVGBE don't automatically select PHYLIB

Quoted 11 lines · Chris Packham

When Kconfig support was added for MVGBE it included automatically selected PHYLIB support. But MVGBE does not need PHYLIB it will build fine without it. Commit ed52ea507f12 ("net: add Kconfig for MVGBE") should have been a no-op in terms of build size but because of the selecting PHYLIB the openrd configs increased in size.

Remove the automatic selection of PHYLIB, boards that need it will have already enabled it in their config header file.

Fixes commit ed52ea507f12 ("net: add Kconfig for MVGBE")
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180517/253bc3b6/attachment.sig>
#2 lore raw

PATCH v2 1/1 net: MVGBE don't automatically select PHYLIB

In reply to Chris Packham
Quoted 11 lines · Chris Packham

When Kconfig support was added for MVGBE it included automatically selected PHYLIB support. But MVGBE does not need PHYLIB it will build fine without it. Commit ed52ea507f12 ("net: add Kconfig for MVGBE") should have been a no-op in terms of build size but because of the selecting PHYLIB the openrd configs increased in size.

Remove the automatic selection of PHYLIB, boards that need it will have already enabled it in their config header file.

Fixes commit ed52ea507f12 ("net: add Kconfig for MVGBE")

Stefan, feel free to pull this through your branch.

Cheers,
-Joe

#3 lore raw

PATCH v2 1/1 net: MVGBE don't automatically select PHYLIB

Quoted 10 lines · Joe Hershberger
Quoted 9 lines · Chris Packham

When Kconfig support was added for MVGBE it included automatically selected PHYLIB support. But MVGBE does not need PHYLIB it will build fine without it. Commit ed52ea507f12 ("net: add Kconfig for MVGBE") should have been a no-op in terms of build size but because of the selecting PHYLIB the openrd configs increased in size.

Remove the automatic selection of PHYLIB, boards that need it will have already enabled it in their config header file.

Quoted 6 lines
Quoted 2 lines
Fixes commit ed52ea507f12 ("net: add Kconfig for MVGBE")

Stefan, feel free to pull this through your branch.

Thanks, will do.

Thanks,
Stefan