Skip to contentSkip to conversation

scripts/tags.sh: don't parse `ls` for $ALLSOURCE_ARCHS generation

PATCH Superseded Joey Pabalinas 1 participant 1 message May 17, 2018

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 scripts/tags.sh: don't parse `ls` for $ALLSOURCE_ARCHS generation

Parsing ls is fragile at best and _will_ fail when $tree contains spaces. Replace this with a glob-generated string and directly assign it to $ALLSOURCE_ARCHS; a subshell is implied by $(), so cd doesn't affect the current working directory.

 1 file changed, 1 insertion(+), 4 deletions(-)
scripts/tags.sh +1 -4
index 78e546ff689c2d5f40..a4b089aa35efbc0a13 100755
@@ -29,14 +29,11 @@ fi
 ignore="$ignore ( -path ${tree}tools ) -prune -o"
 
 # Find all available archs
 find_all_archs()
 {
-	ALLSOURCE_ARCHS=""
-	for arch in `ls ${tree}arch`; do
-		ALLSOURCE_ARCHS="${ALLSOURCE_ARCHS} "${arch##\/}
-	done
+	ALLSOURCE_ARCHS="$(cd "${tree}arch/" && echo *)"
 }
 
 # Detect if ALLSOURCE_ARCHS is set. If not, we assume SRCARCH
 if [ "${ALLSOURCE_ARCHS}" = "" ]; then
 	ALLSOURCE_ARCHS=${SRCARCH}
Signature · 1 line
2.17.0.rc1.35.g90bbd502d54fe92035.dirty