Skip to contentSkip to conversation

drm/v3d: Checking for NULL vs IS_ERR()

PATCH Applied Dan Carpenter 2 participants 2 messages May 18, 2018 – May 21, 2018

Subsystems (4)
DRM drivers DRM misc Kernel janitors DRM drivers for V3D
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drm/v3d: Checking for NULL vs IS_ERR()

The v3d_fence_create() only returns error pointers on error. It never returns NULL.

Fixes 57692c94dcbe ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+")
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/v3d/v3d_sched.c +2 -2
index b07bece9417d..808bc901f567 100644
@@ -114,8 +114,8 @@ static struct dma_fence *v3d_job_run(struct drm_sched_job *sched_job)
 	v3d_invalidate_caches(v3d);
 
 	fence = v3d_fence_create(v3d, q);
-	if (!fence)
-		return fence;
+	if (IS_ERR(fence))
+		return NULL;
 
 	if (job->done_fence)
 		dma_fence_put(job->done_fence);
Applied
#1 lore raw
Quoted 5 lines · Dan Carpenter

The v3d_fence_create() only returns error pointers on error. It never returns NULL.

Fixes 57692c94dcbe ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+")
Signed-off-by Dan Carpenter <[email protected]>

Pushed to drm-misc-next. Thanks!