NFC: pn533: don't send USB data off of the stack
PATCH v3 1/1 NFC: pn533: don't send USB data off of the stack
Quoted 7 lines · Greg Kroah-Hartman
It's amazing that this driver ever worked, but now that x86 doesn't allow USB data to be sent off of the stack, it really does not work at all. Fix this up by properly allocating the data for the small "commands" that get sent to the device.
The USB stack will free the buffer when the data has been transmitted, that is why there is no
kfree()to mirror the call tokmalloc().
It looks like you're now leaking all but the final transfer buffer that is allocated for outgoing commands, as the URBs themselves are not freed until disconnect() (and that's when core would free the buffers along with the URBs if URB_FREE_BUFFER is set).
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html